Bug 198641 - [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
Summary: [iOS] At least 6 API tests are failing due to an exception when writing NSAtt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-06 20:39 PDT by Wenson Hsieh
Modified: 2019-06-07 07:43 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.91 KB, patch)
2019-06-06 21:56 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix open source build (5.11 KB, patch)
2019-06-06 22:18 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-06-06 20:39:48 PDT 
<rdar://problem/51266310>
Comment 1 Wenson Hsieh 2019-06-06 20:41:29 PDT 
They are:
---
WKAttachmentTests.CopyAndPasteBetweenWebViews
WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments
WKAttachmentTests.InsertPastedAttributedStringContainingImage
WKWebViewEditActions.PasteAsQuotation
WKWebViewEditActions.PasteAndMatchStyle
UIPasteboardTests.CopyRichTextWritesConcreteTypes
Comment 2 Wenson Hsieh 2019-06-06 21:56:38 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2019-06-06 22:18:17 PDT 
Created attachment 371559 [details]
Fix open source build
Comment 4 Tim Horton 2019-06-06 23:25:46 PDT 
Comment on attachment 371559 [details]
Fix open source build

View in context: https://bugs.webkit.org/attachment.cgi?id=371559&action=review

> Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:291
> +        swizzler = std::make_unique<ClassMethodSwizzler>(NSAttributedString.class, @selector(writableTypeIdentifiersForItemProvider), reinterpret_cast<IMP>(writableTypeIdentifiersForItemProviderWithoutPublicRTFD));

🤨
Comment 5 Wenson Hsieh 2019-06-07 07:13:09 PDT 
Comment on attachment 371559 [details]
Fix open source build

View in context: https://bugs.webkit.org/attachment.cgi?id=371559&action=review

>> Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:291
>> +        swizzler = std::make_unique<ClassMethodSwizzler>(NSAttributedString.class, @selector(writableTypeIdentifiersForItemProvider), reinterpret_cast<IMP>(writableTypeIdentifiersForItemProviderWithoutPublicRTFD));
> 
> 🤨

🤷🏻‍♂️
Comment 6 WebKit Commit Bot 2019-06-07 07:43:02 PDT 
Comment on attachment 371559 [details]
Fix open source build

Clearing flags on attachment: 371559

Committed r246198: <https://trac.webkit.org/changeset/246198>
Comment 7 WebKit Commit Bot 2019-06-07 07:43:04 PDT 
All reviewed patches have been landed.  Closing bug.