RESOLVED FIXED Bug 198639
Web Inspector: Timelines: only complete Composite records if the m_startedComposite (followup to r246142) 
https://bugs.webkit.org/show_bug.cgi?id=198639
Summary Web Inspector: Timelines: only complete Composite records if the m_startedCom...
Devin Rousso
Reported 2019-06-06 19:03:44 PDT
In r246142, an `ASSERT` was removed because it is possible for Web Inspector to be opened in between `willComposite` and `didComposite`, meaning that previously the `ASSERT` would fire. In order to properly handle this, we should replace the `ASSERT` with an `if` so that we don't even try to complete a `Composite` record if Web Inspector is opened in that case.
Attachments
Patch (1.82 KB, patch)
2019-06-06 19:04 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-06-06 19:04:55 PDT
Created attachment 371549 [details] Patch
Matt Baker
Comment 2 2019-06-06 20:07:12 PDT
Comment on attachment 371549 [details] Patch rs=me
WebKit Commit Bot
Comment 3 2019-06-06 20:38:28 PDT
Comment on attachment 371549 [details] Patch Clearing flags on attachment: 371549 Committed r246186: <https://trac.webkit.org/changeset/246186>
WebKit Commit Bot
Comment 4 2019-06-06 20:38:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-06-06 20:39:15 PDT
<rdar://problem/51510395>
Note You need to log in before you can comment on or make changes to this bug.