Bug 198639 - Web Inspector: Timelines: only complete Composite records if the m_startedComposite (followup to r246142)
Summary: Web Inspector: Timelines: only complete Composite records if the m_startedCom...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 198497
Blocks:
  Show dependency tree / graph
 
Reported: 2019-06-06 19:03 PDT by Devin Rousso
Modified: 2019-06-06 20:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2019-06-06 19:04 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-06 19:03:44 PDT 
In r246142, an `ASSERT` was removed because it is possible for Web Inspector to be opened in between `willComposite` and `didComposite`, meaning that previously the `ASSERT` would fire.  In order to properly handle this, we should replace the `ASSERT` with an `if` so that we don't even try to complete a `Composite` record if Web Inspector is opened in that case.
Comment 1 Devin Rousso 2019-06-06 19:04:55 PDT 
Created attachment 371549 [details]
Patch
Comment 2 Matt Baker 2019-06-06 20:07:12 PDT 
Comment on attachment 371549 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2019-06-06 20:38:28 PDT 
Comment on attachment 371549 [details]
Patch

Clearing flags on attachment: 371549

Committed r246186: <https://trac.webkit.org/changeset/246186>
Comment 4 WebKit Commit Bot 2019-06-06 20:38:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-06-06 20:39:15 PDT 
<rdar://problem/51510395>