Bug 198625 – RELEASE_ASSERT hit in CachedFrame constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

RELEASE_ASSERT hit in CachedFrame constructor:
[  1] 0x0000000106256ffa WebCore`WebCore::CachedFrame::CachedFrame(WebCore::Frame&) + 842 at CachedFrame.cpp:148:5
       138 	{
       139 	#ifndef NDEBUG
       140 	    cachedFrameCounter.increment();
       141 	#endif
       142 	    ASSERT(m_document);
       143 	    ASSERT(m_documentLoader);
       144 	    ASSERT(m_view);
       145 	    ASSERT(m_document->pageCacheState() == Document::InPageCache);
       146 	
       147 	    RELEASE_ASSERT(m_document->domWindow());
    -> 148 	    RELEASE_ASSERT(m_document->frame());
       149 	    RELEASE_ASSERT(m_document->domWindow()->frame());
       150 	
       151 	    // FIXME: We have evidence that constructing CachedFrames for descendant frames may detach the document from its frame (rdar://problem/49877867).
       152 	    // This sets the flag to help find the guilty code.
       153 	    m_document->setMayBeDetachedFromFrame(false);
       154 	
       155 	    // Create the CachedFrames for all Frames in the FrameTree.
       156 	    for (Frame* child = frame.tree().firstChild(); child; child = child->tree().nextSibling())
       157 	        m_childFrames.append(std::make_unique<CachedFrame>(*child));
       158

[Chris Dumez]

<rdar://problem/49877867>

[Chris Dumez]

Created attachment 371529 [details]
Patch

[Geoffrey Garen]

Comment on attachment 371529 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 371529 [details]
Patch

Clearing flags on attachment: 371529

Committed r246187: <https://trac.webkit.org/changeset/246187>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.