WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198625
RELEASE_ASSERT hit in CachedFrame constructor
https://bugs.webkit.org/show_bug.cgi?id=198625
Summary
RELEASE_ASSERT hit in CachedFrame constructor
Chris Dumez
Reported
2019-06-06 15:29:08 PDT
RELEASE_ASSERT hit in CachedFrame constructor: [ 1] 0x0000000106256ffa WebCore`WebCore::CachedFrame::CachedFrame(WebCore::Frame&) + 842 at CachedFrame.cpp:148:5 138 { 139 #ifndef NDEBUG 140 cachedFrameCounter.increment(); 141 #endif 142 ASSERT(m_document); 143 ASSERT(m_documentLoader); 144 ASSERT(m_view); 145 ASSERT(m_document->pageCacheState() == Document::InPageCache); 146 147 RELEASE_ASSERT(m_document->domWindow()); -> 148 RELEASE_ASSERT(m_document->frame()); 149 RELEASE_ASSERT(m_document->domWindow()->frame()); 150 151 // FIXME: We have evidence that constructing CachedFrames for descendant frames may detach the document from its frame (
rdar://problem/49877867
). 152 // This sets the flag to help find the guilty code. 153 m_document->setMayBeDetachedFromFrame(false); 154 155 // Create the CachedFrames for all Frames in the FrameTree. 156 for (Frame* child = frame.tree().firstChild(); child; child = child->tree().nextSibling()) 157 m_childFrames.append(std::make_unique<CachedFrame>(*child)); 158
Attachments
Patch
(2.76 KB, patch)
2019-06-06 15:35 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2019-06-06 15:29:32 PDT
<
rdar://problem/49877867
>
Chris Dumez
Comment 2
2019-06-06 15:35:45 PDT
Created
attachment 371529
[details]
Patch
Geoffrey Garen
Comment 3
2019-06-06 21:19:10 PDT
Comment on
attachment 371529
[details]
Patch r=me
WebKit Commit Bot
Comment 4
2019-06-06 22:14:41 PDT
Comment on
attachment 371529
[details]
Patch Clearing flags on attachment: 371529 Committed
r246187
: <
https://trac.webkit.org/changeset/246187
>
WebKit Commit Bot
Comment 5
2019-06-06 22:14:42 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug