Bug 198620 - [lldb-webkit] Pretty-print all kinds of Documents
Summary: [lldb-webkit] Pretty-print all kinds of Documents
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2019-06-06 12:18 PDT by Daniel Bates
Modified: 2019-06-07 15:58 PDT (History)
5 users (show)

See Also:

Patch (2.55 KB, patch)
2019-06-06 12:23 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-06-06 12:18:40 PDT
We need to add a formatter for each Document derived class in order for LLDB to pretty-print it. Otherwise, you have to manually drill down in Xcode- or cast- to Document* in order for LLDB to emit a pretty-printed summary.

Let's make things just work™ and add formatting for all the derived classes.
Comment 1 Daniel Bates 2019-06-06 12:23:33 PDT
Created attachment 371519 [details]
Comment 2 Daniel Bates 2019-06-07 15:52:37 PDT
Comment on attachment 371519 [details]

Clearing flags on attachment: 371519

Committed r246222: <https://trac.webkit.org/changeset/246222>
Comment 3 Daniel Bates 2019-06-07 15:52:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-06-07 15:58:26 PDT