Bug 198616 – Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

In configurations where stripping is performed, crash logs from bots can lack symbols for tool code. As far as I can tell, it's an Xcode default to strip all symbols from applications and command line tools, but not from frameworks.

rdar://problem/36386573

[Alexey Proskuryakov]

Created attachment 371515 [details]
proposed fix

[Jonathan Bedard]

Comment on attachment 371515 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=371515&action=review

> Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:30
> +STRIP_STYLE=debugging

I would have expected this to be in DebugRelease.xcconfig. I suppose if we set it here, we have more data for Production builds, but if that was what we wanted, why not in Base.xcconfig?

[Alexey Proskuryakov]

Both DebugRelease.xcconfig and Base.xcconfig affect all targets, whereas I only want to change the behavior where it is incorrect. 

One case where we have a value different from all and debugging is plug-in bundles. Since function symbols are present in those, and everything works well, I didn't want to change those.

[Tim Horton]

Comment on attachment 371515 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=371515&action=review

> Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:34
> +STRIP_STYLE=debugging

Style-wise I think spaces around the = and a semicolon at the end are both traditional for xcconfigs.

[David Kilzer (:ddkilzer)]

Comment on attachment 371515 [details]
proposed fix

r=me, but please change code style to:

STRIP_STYLE = debugging;

[Ryan Haddad]

Committed r246282: <https://trac.webkit.org/changeset/246282>