WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
198605
check-webkit-style reports false positive whitespace in multiline macro comment
https://bugs.webkit.org/show_bug.cgi?id=198605
Summary
check-webkit-style reports false positive whitespace in multiline macro comment
Paulo Matos
Reported
2019-06-06 04:02:41 PDT
With multiline macro comments such as: ``` #define FOR_EACH_FP_REGISTER(m) \ /* Parameter/result registers. */ \ macro(m, n(q0), 0, 0) ``` check-webkit-style generates a 'Weird number of spaces at line-start' even though the whole macro /body/, including comment, is indented properly (4 spaces).
Attachments
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2019-06-10 04:29:20 PDT
Can you try again, with a single space before every backslash?
Paulo Matos
Comment 2
2019-06-12 02:56:00 PDT
(In reply to Philippe Normand from
comment #1
)
> Can you try again, with a single space before every backslash?
You mean like this: #define FOR_EACH_GP_REGISTER(macro) \ /* Parameter/result registers. */ \ macro_forward(macro, n(x0), 0, 0) \ macro_forward(macro, n(x1), 0, 0) Doesn't work either. Getting: ERROR: Source/JavaScriptCore/assembler/ARM64Registers.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Paulo Matos
Comment 3
2019-06-12 03:09:29 PDT
For _every_ backslash as in: #define FOO \ /* test */ \ macro_forward(foo) \ macro_forward(bar) doesn't work either.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug