Bug 19859 – Flash plugin on WebKit GTK needs null window quirk

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Aaron Bockover]

Testing WebKit GTK from trunk, I noticed that WebKit would crash if the flash plugin was unloaded.

It appears the PluginQuirkDontSetNullWindowHandleOnDestroy needs to be set for the plugin so the window does not get unset when destroying the plugin. Setting this quirk flag fixes the crash for me. 

I was testing the Flash 10 beta.

[Aaron Bockover]

I just tested Flash 9, and it is ok with having a NULL window set, so this crash is specific to Flash 10 from what I can tell.

[Aaron Bockover]

Created attachment 22052 [details]
Version parsing and null window on destroy quirk for Flash 10

This patch adds version parsing for the Flash plugin. I am not aware of a standardized way to read plugin version information, so parsing it from the description string on a per-plugin basis is unfortunately the best I could come up with.

On Windows, there is a standard API to read version and other metadata from a DLL, which WebKit uses in that port.

If Flash 10 is detected, the PluginQuirkDontSetNullWindowHandleOnDestroy is applied to the plugin. Additionally, since now the Flash version is detected, the PluginQuirkWantsMozillaUserAgent quirk is only applied if Flash 9 or older is detected, like in the Windows port.

[Alp Toker]

Comment on attachment 22052 [details]
Version parsing and null window on destroy quirk for Flash 10

r=me

Nice

[Darin Adler]

http://trac.webkit.org/changeset/37535