WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198585
-[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
https://bugs.webkit.org/show_bug.cgi?id=198585
Summary
-[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
Jer Noble
Reported
2019-06-05 15:45:47 PDT
-[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
Attachments
Patch
(16.81 KB, patch)
2019-06-05 15:49 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch for landing
(16.73 KB, patch)
2019-06-05 16:23 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2019-06-05 15:49:19 PDT
Created
attachment 371442
[details]
Patch
Alex Christensen
Comment 2
2019-06-05 15:56:54 PDT
Comment on
attachment 371442
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=371442&action=review
> Tools/ChangeLog:12 > + * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
We should move this away from the WebKitLegacy directory since it's not just used for WebKitLegacy.
> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm:60 > + [webView performAfterReceivingMessage:@"playing" action:^() { isPlaying = true; }];
I think the () is unnecessary.
Jer Noble
Comment 3
2019-06-05 16:18:01 PDT
(In reply to Alex Christensen from
comment #2
)
> Comment on
attachment 371442
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=371442&action=review
> > > Tools/ChangeLog:12 > > + * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html: > > We should move this away from the WebKitLegacy directory since it's not just > used for WebKitLegacy.
There's not really a good general-purpose location for bundle resources. We should totally add one, but that's probably out-of-scope for this patch.
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm:60 > > + [webView performAfterReceivingMessage:@"playing" action:^() { isPlaying = true; }]; > > I think the () is unnecessary.
Will change, in all the places this pattern appears.
Jer Noble
Comment 4
2019-06-05 16:23:25 PDT
Created
attachment 371447
[details]
Patch for landing
WebKit Commit Bot
Comment 5
2019-06-05 18:22:24 PDT
Comment on
attachment 371447
[details]
Patch for landing Clearing flags on attachment: 371447 Committed
r246136
: <
https://trac.webkit.org/changeset/246136
>
WebKit Commit Bot
Comment 6
2019-06-05 18:22:26 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2019-06-05 18:26:05 PDT
<
rdar://problem/51464985
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug