Bug 198582 - TestWebKitAPI.WKWebView.LocalStorageProcessSuspends is flaky on release builds
Summary: TestWebKitAPI.WKWebView.LocalStorageProcessSuspends is flaky on release builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-05 14:56 PDT by Sihui Liu
Modified: 2019-06-06 13:56 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.25 KB, patch)
2019-06-05 14:58 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-06-05 14:56:54 PDT
Failed

    TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.

        /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:142
        Expected equality of these values:
          @"value"
            Which is: "value"
          result
            Which is: "newValue"
Comment 1 Sihui Liu 2019-06-05 14:58:32 PDT
Created attachment 371440 [details]
Patch
Comment 2 WebKit Commit Bot 2019-06-05 16:05:57 PDT
Comment on attachment 371440 [details]
Patch

Clearing flags on attachment: 371440

Committed r246132: <https://trac.webkit.org/changeset/246132>
Comment 3 WebKit Commit Bot 2019-06-05 16:05:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-06-05 16:06:14 PDT
<rdar://problem/51459712>
Comment 5 Ryosuke Niwa 2019-06-06 13:56:28 PDT
Comment on attachment 371440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371440&action=review

> Source/WebKit/NetworkProcess/WebStorage/StorageManager.h:121
> -    State m_state;
> +    State m_state { State::Running };

We don't enable a warning for uninitialized member variables!?