Bug 198573 - REGRESSION (r243270) [ iOS Sim Release ] Layout Test imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm is a flaky failure
Summary: REGRESSION (r243270) [ iOS Sim Release ] Layout Test imported/w3c/web-platfor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-05 10:57 PDT by Shawn Roberts
Modified: 2019-06-06 16:20 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2019-06-06 09:08 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2019-06-06 15:38 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Roberts 2019-06-05 10:57:23 PDT
The following layout test is flaky on iOS Simulator Release

imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm

Probable cause:

It appears that after changes in r243270 the above test started to fail on iOS Simulator Release only.

Was able to reproduce locally with:'

run-webkit-tests imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm --iter 100 -f --exit-after-n-failures=1 --ios-simulator

Fails locally with revisions up until r243270 and passes in older revisions. It's hitting a harness timeout.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2FIndexedDB%2Fkeypath-special-identifiers.htm

Diff:

--- /Users/shawnroberts/Desktop/builds/ios243270/layout-test-results/imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers-expected.txt
+++ /Users/shawnroberts/Desktop/builds/ios243270/layout-test-results/imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers-actual.txt
@@ -1,8 +1,10 @@
+
+Harness Error (TIMEOUT), message = null
 
 PASS Type: String, identifier: length 
 PASS Type: Array, identifier: length 
-PASS Type: Blob, identifier: size 
-PASS Type: Blob, identifier: type 
-PASS Type: File, identifier: name 
-PASS Type: File, identifier: lastModified 
+TIMEOUT Type: Blob, identifier: size Test timed out
+TIMEOUT Type: Blob, identifier: type Test timed out
+TIMEOUT Type: File, identifier: name Test timed out
+TIMEOUT Type: File, identifier: lastModified Test timed out
Comment 1 Radar WebKit Bug Importer 2019-06-05 10:58:16 PDT
<rdar://problem/51447519>
Comment 2 Shawn Roberts 2019-06-05 11:03:01 PDT
Marked flaky in https://trac.webkit.org/changeset/246117/webkit
Comment 3 youenn fablet 2019-06-06 09:08:13 PDT
Created attachment 371502 [details]
Patch
Comment 4 EWS Watchlist 2019-06-06 09:10:55 PDT
Attachment 371502 [details] did not pass style-queue:


ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-simulator-wk2/TestExpectations:109:  More specific entry for imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm on line LayoutTests/platform/ios-simulator-wk2/TestExpectations:85 overrides line LayoutTests/platform/ios-simulator-wk2/TestExpectations:109.  [test/expectations] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2019-06-06 10:20:10 PDT
Comment on attachment 371502 [details]
Patch

Rejecting attachment 371502 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 371502, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=371502&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=198573&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 371502 from bug 198573.
Fetching: https://bugs.webkit.org/attachment.cgi?id=371502
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/ios-simulator-wk2/TestExpectations']" exit_code: 1

ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/ios-simulator-wk2/TestExpectations:109:  More specific entry for imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm on line LayoutTests/platform/ios-simulator-wk2/TestExpectations:85 overrides line LayoutTests/platform/ios-simulator-wk2/TestExpectations:109.  [test/expectations] [5]
Total errors found: 1 in 1 files

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/ios-simulator-wk2/TestExpectations']" exit_code: 1

ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/ios-simulator-wk2/TestExpectations:109:  More specific entry for imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm on line LayoutTests/platform/ios-simulator-wk2/TestExpectations:85 overrides line LayoutTests/platform/ios-simulator-wk2/TestExpectations:109.  [test/expectations] [5]
Total errors found: 1 in 1 files

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/ios-simulator-wk2/TestExpectations']" exit_code: 1
Updating OpenSource
From https://git.webkit.org/git/WebKit
   5fd7ef15f2b..4abf16d63e0  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 246157 = 5fd7ef15f2b196b9567c63f6464b687190cbdf62
r246158 = 4abf16d63e0d729183048a48ba83ad8b9c54dbb6
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/ios-simulator-wk2/TestExpectations:109:  More specific entry for imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm on line LayoutTests/platform/ios-simulator-wk2/TestExpectations:85 overrides line LayoutTests/platform/ios-simulator-wk2/TestExpectations:109.  [test/expectations] [5]
Total errors found: 1 in 1 files

Full output: https://webkit-queues.webkit.org/results/12396759
Comment 6 youenn fablet 2019-06-06 15:38:30 PDT
Created attachment 371530 [details]
Patch
Comment 7 WebKit Commit Bot 2019-06-06 16:20:05 PDT
Comment on attachment 371530 [details]
Patch

Clearing flags on attachment: 371530

Committed r246175: <https://trac.webkit.org/changeset/246175>
Comment 8 WebKit Commit Bot 2019-06-06 16:20:07 PDT
All reviewed patches have been landed.  Closing bug.