Bug 198565 - [LFC][IFC] LineLayout::placeInlineItems should not apply float contraint.
Summary: [LFC][IFC] LineLayout::placeInlineItems should not apply float contraint.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-05 08:05 PDT by zalan
Modified: 2019-06-05 10:34 PDT (History)
8 users (show)

See Also:

Attachments
Patch (13.75 KB, patch)
2019-06-05 08:25 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (13.74 KB, patch)
2019-06-05 08:41 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.79 MB, application/zip)
2019-06-05 09:55 PDT, EWS Watchlist 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-06-05 08:05:58 PDT 
its caller, LineLayout::layout should do it instead.
Comment 1 Radar WebKit Bug Importer 2019-06-05 08:06:20 PDT 
<rdar://problem/51440718>
Comment 2 zalan 2019-06-05 08:25:58 PDT 
Created attachment 371398 [details]
Patch
Comment 3 Antti Koivisto 2019-06-05 08:33:46 PDT 
Comment on attachment 371398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371398&action=review

> Source/WebCore/ChangeLog:10
> +        When placeInlineItems() is called by the preferred width computation, intruding floats should can be ignored

typo 'should can'
Comment 4 zalan 2019-06-05 08:41:12 PDT 
Created attachment 371400 [details]
Patch
Comment 5 EWS Watchlist 2019-06-05 09:55:30 PDT 
Comment on attachment 371400 [details]
Patch

Attachment 371400 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12385388

New failing tests:
http/wpt/service-workers/service-worker-networkprocess-crash.html
Comment 6 EWS Watchlist 2019-06-05 09:55:31 PDT 
Created attachment 371413 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 7 zalan 2019-06-05 10:03:12 PDT 
(In reply to Build Bot from comment #5)
> Comment on attachment 371400 [details]
> Patch
> 
> Attachment 371400 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: https://webkit-queues.webkit.org/results/12385388
> 
> New failing tests:
> http/wpt/service-workers/service-worker-networkprocess-crash.html
srsly?
Comment 8 WebKit Commit Bot 2019-06-05 10:34:26 PDT 
Comment on attachment 371400 [details]
Patch

Clearing flags on attachment: 371400

Committed r246114: <https://trac.webkit.org/changeset/246114>
Comment 9 WebKit Commit Bot 2019-06-05 10:34:27 PDT 
All reviewed patches have been landed.  Closing bug.