Bug 198551 - Remove SSL-based tests from TestWebKitAPI on some configurations
Summary: Remove SSL-based tests from TestWebKitAPI on some configurations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-04 19:12 PDT by Keith Rollin
Modified: 2019-06-06 15:34 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2019-06-04 19:14 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2019-06-05 10:37 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Patch (4.81 KB, patch)
2019-06-06 12:49 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-06-04 19:12:31 PDT 
TestWebKitAPI doesn't build on all configurations and is not used on all configurations. It doesn't build on tvOS simulator due to missing SSL functions. And it's not (yet) utilized on actual embedded devices. In light of all this, only build TestWebKitAPI on macOS, iOS Simulator, and watchOS simulator.
Comment 1 Radar WebKit Bug Importer 2019-06-04 19:12:44 PDT 
<rdar://problem/51424996>
Comment 2 Keith Rollin 2019-06-04 19:14:39 PDT 
Created attachment 371362 [details]
Patch
Comment 3 Jonathan Bedard 2019-06-05 08:35:31 PDT 
Comment on attachment 371362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371362&action=review

> Tools/Makefile:7
> +		ifneq (,$(findstring simulator,$(SDKROOT)))		# Include TestWebKitAPI for simulators...

We do build TestWebKitAPI for embedded devices now...I'd be curious if you encountered problems doing so.
Comment 4 Keith Rollin 2019-06-05 10:30:52 PDT 
tvOS has the same issue as tvSimulator. So should we just prevent tvOS/Simulator from building TestWebKitAPI?
Comment 5 Keith Rollin 2019-06-05 10:37:53 PDT 
Created attachment 371419 [details]
Patch
Comment 6 Chris Dumez 2019-06-05 10:49:36 PDT 
Comment on attachment 371419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371419&action=review

> Tools/Makefile:7
> +		ifeq (,$(findstring appletv,$(SDKROOT)))  # Don't build TestWebKitAPI on AppleTV, due to missing SSL support

Alex, isn't this just your new test server? Can we just disable Alex's new test server for Apple TV. Disabling building ALL tests seems aggressive.
Comment 7 Alex Christensen 2019-06-05 10:55:05 PDT 
Comment on attachment 371419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371419&action=review

>> Tools/Makefile:7
>> +		ifeq (,$(findstring appletv,$(SDKROOT)))  # Don't build TestWebKitAPI on AppleTV, due to missing SSL support
> 
> Alex, isn't this just your new test server? Can we just disable Alex's new test server for Apple TV. Disabling building ALL tests seems aggressive.

We could either build libwebrtc's boringssl on AppleTV and link with it, or we could just add preprocessor macros to all use of TCPServer in TestWebKitAPI.  I agree, disabling all tests would be a bad thing.
Comment 8 Keith Rollin 2019-06-05 10:56:09 PDT 
(In reply to Alex Christensen from comment #7)
> we could just add preprocessor macros to all use of TCPServer in
> TestWebKitAPI.  I agree, disabling all tests would be a bad thing.

I'll look into this one.
Comment 9 Keith Rollin 2019-06-06 12:49:28 PDT 
Created attachment 371521 [details]
Patch
Comment 10 WebKit Commit Bot 2019-06-06 15:34:56 PDT 
Comment on attachment 371521 [details]
Patch

Clearing flags on attachment: 371521

Committed r246173: <https://trac.webkit.org/changeset/246173>
Comment 11 WebKit Commit Bot 2019-06-06 15:34:58 PDT 
All reviewed patches have been landed.  Closing bug.