TestWebKitAPI doesn't build on all configurations and is not used on all configurations. It doesn't build on tvOS simulator due to missing SSL functions. And it's not (yet) utilized on actual embedded devices. In light of all this, only build TestWebKitAPI on macOS, iOS Simulator, and watchOS simulator.
<rdar://problem/51424996>
Created attachment 371362 [details] Patch
Comment on attachment 371362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371362&action=review > Tools/Makefile:7 > + ifneq (,$(findstring simulator,$(SDKROOT))) # Include TestWebKitAPI for simulators... We do build TestWebKitAPI for embedded devices now...I'd be curious if you encountered problems doing so.
tvOS has the same issue as tvSimulator. So should we just prevent tvOS/Simulator from building TestWebKitAPI?
Created attachment 371419 [details] Patch
Comment on attachment 371419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371419&action=review > Tools/Makefile:7 > + ifeq (,$(findstring appletv,$(SDKROOT))) # Don't build TestWebKitAPI on AppleTV, due to missing SSL support Alex, isn't this just your new test server? Can we just disable Alex's new test server for Apple TV. Disabling building ALL tests seems aggressive.
Comment on attachment 371419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371419&action=review >> Tools/Makefile:7 >> + ifeq (,$(findstring appletv,$(SDKROOT))) # Don't build TestWebKitAPI on AppleTV, due to missing SSL support > > Alex, isn't this just your new test server? Can we just disable Alex's new test server for Apple TV. Disabling building ALL tests seems aggressive. We could either build libwebrtc's boringssl on AppleTV and link with it, or we could just add preprocessor macros to all use of TCPServer in TestWebKitAPI. I agree, disabling all tests would be a bad thing.
(In reply to Alex Christensen from comment #7) > we could just add preprocessor macros to all use of TCPServer in > TestWebKitAPI. I agree, disabling all tests would be a bad thing. I'll look into this one.
Created attachment 371521 [details] Patch
Comment on attachment 371521 [details] Patch Clearing flags on attachment: 371521 Committed r246173: <https://trac.webkit.org/changeset/246173>
All reviewed patches have been landed. Closing bug.