Bug 198551 – Remove SSL-based tests from TestWebKitAPI on some configurations

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Keith Rollin]

TestWebKitAPI doesn't build on all configurations and is not used on all configurations. It doesn't build on tvOS simulator due to missing SSL functions. And it's not (yet) utilized on actual embedded devices. In light of all this, only build TestWebKitAPI on macOS, iOS Simulator, and watchOS simulator.

[Radar WebKit Bug Importer]

<rdar://problem/51424996>

[Keith Rollin]

Created attachment 371362 [details]
Patch

[Jonathan Bedard]

Comment on attachment 371362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371362&action=review

> Tools/Makefile:7
> +		ifneq (,$(findstring simulator,$(SDKROOT)))		# Include TestWebKitAPI for simulators...

We do build TestWebKitAPI for embedded devices now...I'd be curious if you encountered problems doing so.

[Keith Rollin]

tvOS has the same issue as tvSimulator. So should we just prevent tvOS/Simulator from building TestWebKitAPI?

[Keith Rollin]

Created attachment 371419 [details]
Patch

[Chris Dumez]

Comment on attachment 371419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371419&action=review

> Tools/Makefile:7
> +		ifeq (,$(findstring appletv,$(SDKROOT)))  # Don't build TestWebKitAPI on AppleTV, due to missing SSL support

Alex, isn't this just your new test server? Can we just disable Alex's new test server for Apple TV. Disabling building ALL tests seems aggressive.

[Alex Christensen]

Comment on attachment 371419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371419&action=review

>> Tools/Makefile:7
>> +		ifeq (,$(findstring appletv,$(SDKROOT)))  # Don't build TestWebKitAPI on AppleTV, due to missing SSL support
> 
> Alex, isn't this just your new test server? Can we just disable Alex's new test server for Apple TV. Disabling building ALL tests seems aggressive.

We could either build libwebrtc's boringssl on AppleTV and link with it, or we could just add preprocessor macros to all use of TCPServer in TestWebKitAPI.  I agree, disabling all tests would be a bad thing.

[Keith Rollin]

(In reply to Alex Christensen from comment #7)
> we could just add preprocessor macros to all use of TCPServer in
> TestWebKitAPI.  I agree, disabling all tests would be a bad thing.

I'll look into this one.

[Keith Rollin]

Created attachment 371521 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 371521 [details]
Patch

Clearing flags on attachment: 371521

Committed r246173: <https://trac.webkit.org/changeset/246173>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.