RESOLVED FIXED 198541
[ContentChangeObserver] Gmail text editing controls require two taps 
https://bugs.webkit.org/show_bug.cgi?id=198541
Summary [ContentChangeObserver] Gmail text editing controls require two taps
zalan
Reported 2019-06-04 13:33:15 PDT
<rdar://problem/51375055>
Attachments
Patch (11.29 KB, patch)
2019-06-04 14:29 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2019-06-04 14:29:17 PDT
Created attachment 371336 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-06-04 16:11:05 PDT
Comment on attachment 371336 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371336&action=review > Source/WebCore/page/ios/ContentChangeObserver.cpp:98 > + return element.Element::willRespondToMouseClickEvents(); Ugh. Would it be nicer to add an argument to willRespondToMouseClickEvents() saying whether it's for the touch callout?
zalan
Comment 3 2019-06-04 20:46:20 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 371336 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371336&action=review > > > Source/WebCore/page/ios/ContentChangeObserver.cpp:98 > > + return element.Element::willRespondToMouseClickEvents(); > > Ugh. Would it be nicer to add an argument to willRespondToMouseClickEvents() > saying whether it's for the touch callout? Let me think about it.
WebKit Commit Bot
Comment 4 2019-06-04 21:15:27 PDT
Comment on attachment 371336 [details] Patch Clearing flags on attachment: 371336 Committed r246096: <https://trac.webkit.org/changeset/246096>
WebKit Commit Bot
Comment 5 2019-06-04 21:15:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.