Bug 198541 - [ContentChangeObserver] Gmail text editing controls require two taps
Summary: [ContentChangeObserver] Gmail text editing controls require two taps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-04 13:33 PDT by zalan
Modified: 2019-06-04 21:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.29 KB, patch)
2019-06-04 14:29 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-06-04 13:33:15 PDT
<rdar://problem/51375055>
Comment 1 zalan 2019-06-04 14:29:17 PDT
Created attachment 371336 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-06-04 16:11:05 PDT
Comment on attachment 371336 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371336&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:98
> +        return element.Element::willRespondToMouseClickEvents();

Ugh. Would it be nicer to add an argument to willRespondToMouseClickEvents() saying whether it's for the touch callout?
Comment 3 zalan 2019-06-04 20:46:20 PDT
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 371336 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371336&action=review
> 
> > Source/WebCore/page/ios/ContentChangeObserver.cpp:98
> > +        return element.Element::willRespondToMouseClickEvents();
> 
> Ugh. Would it be nicer to add an argument to willRespondToMouseClickEvents()
> saying whether it's for the touch callout?
Let me think about it.
Comment 4 WebKit Commit Bot 2019-06-04 21:15:27 PDT
Comment on attachment 371336 [details]
Patch

Clearing flags on attachment: 371336

Committed r246096: <https://trac.webkit.org/changeset/246096>
Comment 5 WebKit Commit Bot 2019-06-04 21:15:29 PDT
All reviewed patches have been landed.  Closing bug.