Bug 198539 - Fix 64-bit vs 32-bit mismatch in ISOFairPlayStreamingPsshBox.cpp
Summary: Fix 64-bit vs 32-bit mismatch in ISOFairPlayStreamingPsshBox.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-06-04 12:54 PDT by Keith Rollin
Modified: 2019-06-04 17:40 PDT (History)
4 users (show)

See Also:

Patch (2.36 KB, patch)
2019-06-04 13:02 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-06-04 12:54:43 PDT
Both ISOFairPlayStreamingKeyAssetIdBox and ISOFairPlayStreamingKeyContextBox have Vector<> data members. The parse() members of these classes call Vector<>::resize() on these members. In both cases, the type of the parameter passed is a uint64_t. However, resize() takes a size_t. On some platforms, size_t is a 32-bit value, leading to a compile-time type mismatch error. Fix this by changing the type of the value passed to parse() into a size_t.
Comment 1 Radar WebKit Bug Importer 2019-06-04 12:54:57 PDT
Comment 2 Keith Rollin 2019-06-04 13:02:36 PDT
Created attachment 371322 [details]
Comment 3 WebKit Commit Bot 2019-06-04 17:40:41 PDT
Comment on attachment 371322 [details]

Clearing flags on attachment: 371322

Committed r246092: <https://trac.webkit.org/changeset/246092>
Comment 4 WebKit Commit Bot 2019-06-04 17:40:43 PDT
All reviewed patches have been landed.  Closing bug.