WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198535
Fix icons positioned incorrectly when a featured image is used
https://bugs.webkit.org/show_bug.cgi?id=198535
Summary
Fix icons positioned incorrectly when a featured image is used
Jon Davis
Reported
2019-06-04 10:06:57 PDT
Blog post icons are positioned incorrectly when a featured image is loaded.
Attachments
Patch
(1.74 KB, patch)
2019-06-04 10:09 PDT
,
Jon Davis
no flags
Details
Formatted Diff
Diff
Patch
(1.32 KB, patch)
2019-06-05 10:53 PDT
,
Jon Davis
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jon Davis
Comment 1
2019-06-04 10:09:43 PDT
Created
attachment 371296
[details]
Patch
Devin Rousso
Comment 2
2019-06-04 10:44:52 PDT
Comment on
attachment 371296
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=371296&action=review
rs=me
> Websites/webkit.org/ChangeLog:-101 > -
I don't think we normally go back and edit ChangeLog entries, no matter how "bad" they may be.
WebKit Commit Bot
Comment 3
2019-06-04 19:45:21 PDT
Comment hidden (obsolete)
Comment on
attachment 371296
[details]
Patch Rejecting
attachment 371296
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 371296, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as
commit-queue@webkit.org
... Fetching:
https://bugs.webkit.org/attachment.cgi?id=371296&action=edit
Fetching:
https://bugs.webkit.org/show_bug.cgi?id=198535
&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 371296 from
bug 198535
. Fetching:
https://bugs.webkit.org/attachment.cgi?id=371296
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Devin Rousso']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Websites/webkit.org/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Hunk #2 FAILED at 109. 1 out of 2 hunks FAILED -- saving rejects to file Websites/webkit.org/ChangeLog.rej patching file Websites/webkit.org/wp-content/themes/webkit/style.css Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Devin Rousso']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Websites/webkit.org/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Hunk #2 FAILED at 109. 1 out of 2 hunks FAILED -- saving rejects to file Websites/webkit.org/ChangeLog.rej patching file Websites/webkit.org/wp-content/themes/webkit/style.css Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Devin Rousso']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From
https://git.webkit.org/git/WebKit
28e52f685f4..bc5fed4656a master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 246093 = 28e52f685f4b3dee75008f822a48b9c4aa4ecf61
r246094
= bc5fed4656a6d3f58f222ee13d987f329ad24fe9 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output:
https://webkit-queues.webkit.org/results/12380039
Jon Davis
Comment 4
2019-06-05 10:53:24 PDT
Created
attachment 371420
[details]
Patch
WebKit Commit Bot
Comment 5
2019-06-05 11:23:55 PDT
Comment on
attachment 371420
[details]
Patch Clearing flags on attachment: 371420 Committed
r246119
: <
https://trac.webkit.org/changeset/246119
>
WebKit Commit Bot
Comment 6
2019-06-05 11:23:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2019-06-05 11:24:17 PDT
<
rdar://problem/51448676
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug