Bug 198526 - [GTK][WPE] Re-enable process warming
Summary: [GTK][WPE] Re-enable process warming
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2019-06-04 06:00 PDT by Carlos Garcia Campos
Modified: 2019-06-05 00:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.26 KB, patch)
2019-06-04 06:05 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-06-04 06:00:11 PDT
It was disabled in r243490 because bubblewrap sandbox needs a valid WebsiteDataStore before launching the web process. We can use the default WebsiteDataStore from the WebProcessPool and only use the prewarmed process later if the given WebsiteDataStore is the same as the WebProcessPool one.
Comment 1 Carlos Garcia Campos 2019-06-04 06:05:13 PDT
Created attachment 371271 [details]
Patch
Comment 2 Michael Catanzaro 2019-06-04 06:50:18 PDT
Comment on attachment 371271 [details]
Patch

Excellent! I had hoped something like this might work....
Comment 3 Carlos Garcia Campos 2019-06-05 00:42:16 PDT
Committed r246101: <https://trac.webkit.org/changeset/246101>
Comment 4 Radar WebKit Bug Importer 2019-06-05 00:43:18 PDT
<rdar://problem/51431462>