Bug 198521 - [GTK] Documentation is built even when setting says it is off
Summary: [GTK] Documentation is built even when setting says it is off
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-04 02:27 PDT by Xabier Rodríguez Calvar
Modified: 2019-06-04 06:36 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2019-06-04 02:27:24 PDT 
...
--  ENABLE_GTKDOC                            OFF
...
--  ENABLE_INTROSPECTION                     OFF
...
[6148/6200] Generating ../docs-build-no-html.stamp
Comment 1 Michael Catanzaro 2019-06-04 05:22:03 PDT 
That's the test target for ENABLE_DEVELOPER_MODE which checks that the docs can be built but skips HTML output generation. If you don't want it to use gtkdoc at all, then you should not use developer mode.

ADD_GTKDOC_GENERATOR("docs-build.stamp" "--gtk")
if (ENABLE_GTKDOC)
    add_custom_target(gtkdoc ALL DEPENDS "${CMAKE_BINARY_DIR}/docs-build.stamp")
elseif (NOT ENABLED_COMPILER_SANITIZERS AND NOT CMAKE_CROSSCOMPILING AND NOT APPLE)
    add_custom_target(gtkdoc DEPENDS "${CMAKE_BINARY_DIR}/docs-build.stamp")

    # Add a default build step which check that documentation does not have any warnings
    # or errors. This is useful to prevent breaking documentation inadvertently during
    # the course of development.
    if (DEVELOPER_MODE)
        ADD_GTKDOC_GENERATOR("docs-build-no-html.stamp" "--gtk;--skip-html")
        add_custom_target(gtkdoc-no-html ALL DEPENDS "${CMAKE_BINARY_DIR}/docs-build-no-html.stamp")
    endif ()
endif ()
Comment 2 Xabier Rodríguez Calvar 2019-06-04 05:59:50 PDT 
What's the rationale behind this? Even in developer mode, it is very confusing to deactivate something and getting it anyway.
Comment 3 Carlos Garcia Campos 2019-06-04 06:08:56 PDT 
Docs are not generated (there's no generated html documentation), but gtk-doc is used to check there aren't errors in documentation like undocumented symbols. It could be renamed to ENABLE_API_DOCUMENTATION for example, if that's clearer.
Comment 4 Michael Catanzaro 2019-06-04 06:36:14 PDT 
(In reply to Xabier Rodríguez Calvar from comment #2)
> What's the rationale behind this?

Before we added this, developers who built with gtkdoc disabled kept breaking the docs build. :)