Make it possible for validate-committer-lists to dump a mailmap file
Created attachment 371249 [details] Patch
Attachment 371249 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
e.g. before: Author: rniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> After: Author: Ryosuke Niwa <rniwa@webkit.org>
Comment on attachment 371249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371249&action=review > Tools/Scripts/webkitpy/common/config/contributors.json:6042 > + "youenn.fablet@crf.canon.fr" So one thing I’m unsure of is whether secondary emails in contributors.json can be used to set cq+ in bugzilla. If so, then adding historical emails that people no longer control (old employers, expired domains) is not good.
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 371249 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371249&action=review > > > Tools/Scripts/webkitpy/common/config/contributors.json:6042 > > + "youenn.fablet@crf.canon.fr" > > So one thing I’m unsure of is whether secondary emails in contributors.json > can be used to set cq+ in bugzilla. If so, then adding historical emails > that people no longer control (old employers, expired domains) is not good. Good question! Will have to check; could always add a “retired” addresses section.
Created attachment 372034 [details] Patch
OK, let's start with just the mailman part, we can add more addresses later.
Comment on attachment 372034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372034&action=review > Tools/Scripts/validate-committer-lists:342 > + return "<{0}@268f45cc-cd09-0410-ab3c-d52691b4dbfc>".format(email) Huh?
(In reply to Simon Fraser (smfr) from comment #8) > Comment on attachment 372034 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372034&action=review > > > Tools/Scripts/validate-committer-lists:342 > > + return "<{0}@268f45cc-cd09-0410-ab3c-d52691b4dbfc>".format(email) > > Huh? It's some hash of something that git-svn uses to identify the (svn.webkit.org) origin, as far as I can tell. It's stable and consistent for our Git mirror.
Comment on attachment 372034 [details] Patch Clearing flags on attachment: 372034 Committed r246414: <https://trac.webkit.org/changeset/246414>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51722355>