Bug 198488 – [iOS] Do not prevent app suspension for more than 20 seconds after getting backgrounded

• Status: REOPENED
• Component: WebKit2

[Chris Dumez]

Do not prevent app suspension for more than 20 seconds after getting backgrounded on iOS. We do this by implementing our own expiration handler which notifies our child processes of their imminent suspension before ending the background task that was preventing suspension.

[Chris Dumez]

<rdar://problem/50837208>

[Chris Dumez]

Created attachment 371194 [details]
Patch

[EWS Watchlist]

Comment on attachment 371194 [details]
Patch

Attachment 371194 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12364580

New failing tests:
http/wpt/service-workers/service-worker-networkprocess-crash.html

[EWS Watchlist]

Created attachment 371201 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Geoffrey Garen]

Comment on attachment 371194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371194&action=review

r=me

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:236
> +    [self _cancelPendingReleaseTask];
> +    [self _cancelTimeoutTask];

Naming inconsistency is a little annoying here. 

I think the right naming is probabaly

    _cancelPendingReleaseTask => _cancelReleaseTask
    _pendingReleaseTask => _releaseTask
    _pendingTimeoutTask => _timeoutTask

[Chris Dumez]

Created attachment 371227 [details]
Patch

[Chris Dumez]

Created attachment 371230 [details]
Patch

[Chris Dumez]

Comment on attachment 371230 [details]
Patch

Clearing flags on attachment: 371230

Committed r246053: <https://trac.webkit.org/changeset/246053>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Jer Noble]

Rolled out r246053 for reason:

This changeset caused media playback when the hosting application is backgrounded to break.

Committed r247109: <https://trac.webkit.org/changeset/247109/webkit>

[Ryosuke Niwa]

Was this ever fixed some other way?