Use std::hypot() where possible
Created attachment 371188 [details] WIP
Attachment 371188 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:245: p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:246: p1p2_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:268: orth_p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 371253 [details] WIP
Attachment 371253 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:245: p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:246: p1p2_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:268: orth_p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 371261 [details] WIP
Attachment 371261 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:245: p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:246: p1p2_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:268: orth_p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 371261 [details] WIP Attachment 371261 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12371939 New failing tests: imported/blink/compositing/layer-creation/iframe-clip-removed.html
Created attachment 371274 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 372226 [details] WIP
Created attachment 379364 [details] WIP
Created attachment 379442 [details] Patch
Created attachment 380193 [details] Patch for landing
Created attachment 389496 [details] Patch for landing
Comment on attachment 389496 [details] Patch for landing Clearing flags on attachment: 389496 Committed r255559: <https://trac.webkit.org/changeset/255559>
All reviewed patches have been landed. Closing bug.
<rdar://problem/59108473>