198468 – [Pointer Events] Expose navigator.maxTouchPoints

RESOLVED FIXED198468

[Pointer Events] Expose navigator.maxTouchPoints

https://bugs.webkit.org/show_bug.cgi?id=198468

Summary [Pointer Events] Expose navigator.maxTouchPoints

Antoine Quint

Reported 2019-06-02 06:28:37 PDT

[Pointer Events] Expose navigator.maxTouchPoints

Attachments
Patch (12.47 KB, patch) 2019-06-02 06:32 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.09 MB, application/zip) 2019-06-02 07:45 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.81 MB, application/zip) 2019-06-02 07:53 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews215 for win-future (13.48 MB, application/zip) 2019-06-02 08:00 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.54 MB, application/zip) 2019-06-02 08:16 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-highsierra (2.90 MB, application/zip) 2019-06-02 08:25 PDT, EWS Watchlist	no flags	Details
Patch (14.39 KB, patch) 2019-06-04 08:30 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (14.23 KB, patch) 2019-06-04 08:46 PDT, Antoine Quint	cdumez: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-highsierra (3.08 MB, application/zip) 2019-06-04 09:44 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.78 MB, application/zip) 2019-06-04 09:57 PDT, EWS Watchlist	no flags	Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2019-06-02 06:32:28 PDT

Created attachment 371146 [details] Patch

Antoine Quint

Comment 2 2019-06-02 06:33:15 PDT

Note to reviewers: is it correct to modify NavigatorBase.h for this?

EWS Watchlist

Comment 3 2019-06-02 07:45:31 PDT

Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12355867 New failing tests: fast/dom/navigator-detached-no-crash.html

EWS Watchlist

Comment 4 2019-06-02 07:45:33 PDT

Created attachment 371150 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-06-02 07:53:18 PDT

Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12355881 New failing tests: fast/dom/navigator-detached-no-crash.html

EWS Watchlist

Comment 6 2019-06-02 07:53:20 PDT

Created attachment 371151 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-06-02 07:59:59 PDT

Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12355897 New failing tests: js/dom/navigator-maxtouchpoints.html

EWS Watchlist

Comment 8 2019-06-02 08:00:01 PDT

Created attachment 371152 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

EWS Watchlist

Comment 9 2019-06-02 08:16:51 PDT

Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12355919 New failing tests: js/dom/navigator-maxtouchpoints.html

EWS Watchlist

Comment 10 2019-06-02 08:16:52 PDT

Created attachment 371153 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

EWS Watchlist

Comment 11 2019-06-02 08:25:13 PDT

Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12355902 New failing tests: fast/dom/navigator-detached-no-crash.html

EWS Watchlist

Comment 12 2019-06-02 08:25:14 PDT

Created attachment 371154 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6

Antoine Quint

Comment 13 2019-06-04 08:30:06 PDT

Created attachment 371283 [details] Patch

Chris Dumez

Comment 14 2019-06-04 08:34:49 PDT

Comment on attachment 371283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371283&action=review > Source/WebCore/page/NavigatorBase.h:76 > + int maxTouchPoints() const { return 5; } Why is this on NavigatorBase and not Navigator? It does not look like you're exposing this to workers.

Chris Dumez

Comment 15 2019-06-04 08:37:18 PDT

Comment on attachment 371283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371283&action=review > LayoutTests/js/dom/navigator-maxtouchpoints.html:9 > + "<pre>Check return value of navigator.maxTouchPoints." Why the <pre> ? > LayoutTests/js/dom/navigator-maxtouchpoints.html:13 > + testRunner.dumpAsText(); Not needed with js-test. > LayoutTests/js/dom/navigator-maxtouchpoints.html:17 > +<script src="../../resources/js-test-post.js"></script> The modern way is to include js-test.js in the <head> and then you would not need this.

Antoine Quint

Comment 16 2019-06-04 08:46:45 PDT

Created attachment 371287 [details] Patch

Chris Dumez

Comment 17 2019-06-04 08:48:12 PDT

Comment on attachment 371287 [details] Patch r=me if the bots are happy.

Antoine Quint

Comment 18 2019-06-04 08:48:36 PDT

(In reply to Chris Dumez from comment #15) > Comment on attachment 371283 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371283&action=review > > > LayoutTests/js/dom/navigator-maxtouchpoints.html:9 > > + "<pre>Check return value of navigator.maxTouchPoints." > > Why the <pre> ? > > > LayoutTests/js/dom/navigator-maxtouchpoints.html:13 > > + testRunner.dumpAsText(); > > Not needed with js-test. > > > LayoutTests/js/dom/navigator-maxtouchpoints.html:17 > > +<script src="../../resources/js-test-post.js"></script> > > The modern way is to include js-test.js in the <head> and then you would not > need this. Thanks for the feedback, this is all addressed in the newer patch.

EWS Watchlist

Comment 19 2019-06-04 09:44:43 PDT

Comment on attachment 371287 [details] Patch Attachment 371287 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12373792 New failing tests: fast/dom/navigator-detached-no-crash.html

EWS Watchlist

Comment 20 2019-06-04 09:44:45 PDT

Created attachment 371292 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 21 2019-06-04 09:57:51 PDT

Comment on attachment 371287 [details] Patch Attachment 371287 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12373936 New failing tests: fast/dom/navigator-detached-no-crash.html

EWS Watchlist

Comment 22 2019-06-04 09:57:53 PDT

Created attachment 371294 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Antoine Quint

Comment 23 2019-06-04 10:45:51 PDT

Committed r246070: <https://trac.webkit.org/changeset/246070>

Radar WebKit Bug Importer

Comment 24 2019-06-04 10:46:26 PDT

<rdar://problem/51405070>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component UI Events

Assignee

Antoine Quint

Reported

2019-06-02 06:28 PDT

Modified

2019-06-04 10:46 PDT History

CC List

6 users Show

URL

Keywords InRadar

Depends on

Blocks