[Pointer Events] Expose navigator.maxTouchPoints
Created attachment 371146 [details] Patch
Note to reviewers: is it correct to modify NavigatorBase.h for this?
Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12355867 New failing tests: fast/dom/navigator-detached-no-crash.html
Created attachment 371150 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12355881 New failing tests: fast/dom/navigator-detached-no-crash.html
Created attachment 371151 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12355897 New failing tests: js/dom/navigator-maxtouchpoints.html
Created attachment 371152 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12355919 New failing tests: js/dom/navigator-maxtouchpoints.html
Created attachment 371153 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Comment on attachment 371146 [details] Patch Attachment 371146 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12355902 New failing tests: fast/dom/navigator-detached-no-crash.html
Created attachment 371154 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371283 [details] Patch
Comment on attachment 371283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371283&action=review > Source/WebCore/page/NavigatorBase.h:76 > + int maxTouchPoints() const { return 5; } Why is this on NavigatorBase and not Navigator? It does not look like you're exposing this to workers.
Comment on attachment 371283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371283&action=review > LayoutTests/js/dom/navigator-maxtouchpoints.html:9 > + "<pre>Check return value of navigator.maxTouchPoints." Why the <pre> ? > LayoutTests/js/dom/navigator-maxtouchpoints.html:13 > + testRunner.dumpAsText(); Not needed with js-test. > LayoutTests/js/dom/navigator-maxtouchpoints.html:17 > +<script src="../../resources/js-test-post.js"></script> The modern way is to include js-test.js in the <head> and then you would not need this.
Created attachment 371287 [details] Patch
Comment on attachment 371287 [details] Patch r=me if the bots are happy.
(In reply to Chris Dumez from comment #15) > Comment on attachment 371283 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371283&action=review > > > LayoutTests/js/dom/navigator-maxtouchpoints.html:9 > > + "<pre>Check return value of navigator.maxTouchPoints." > > Why the <pre> ? > > > LayoutTests/js/dom/navigator-maxtouchpoints.html:13 > > + testRunner.dumpAsText(); > > Not needed with js-test. > > > LayoutTests/js/dom/navigator-maxtouchpoints.html:17 > > +<script src="../../resources/js-test-post.js"></script> > > The modern way is to include js-test.js in the <head> and then you would not > need this. Thanks for the feedback, this is all addressed in the newer patch.
Comment on attachment 371287 [details] Patch Attachment 371287 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12373792 New failing tests: fast/dom/navigator-detached-no-crash.html
Created attachment 371292 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 371287 [details] Patch Attachment 371287 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12373936 New failing tests: fast/dom/navigator-detached-no-crash.html
Created attachment 371294 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Committed r246070: <https://trac.webkit.org/changeset/246070>
<rdar://problem/51405070>