RESOLVED FIXED 198459
Web Inspector: Canvas: split recording tests into separate files so they don't timeout 
https://bugs.webkit.org/show_bug.cgi?id=198459
Summary Web Inspector: Canvas: split recording tests into separate files so they don'...
Devin Rousso
Reported 2019-06-01 12:11:30 PDT
.
Attachments
Patch (326.71 KB, patch)
2019-06-01 12:27 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (328.61 KB, patch)
2019-06-01 12:42 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-01 12:17:17 PDT
<rdar://problem/51332026>
Devin Rousso
Comment 2 2019-06-01 12:27:09 PDT
Created attachment 371120 [details] Patch
EWS Watchlist
Comment 3 2019-06-01 12:29:30 PDT Comment hidden (obsolete)
Joseph Pecoraro
Comment 4 2019-06-01 12:30:15 PDT
Comment on attachment 371120 [details] Patch rs=me
Devin Rousso
Comment 5 2019-06-01 12:42:42 PDT
Created attachment 371121 [details] Patch
WebKit Commit Bot
Comment 6 2019-06-01 14:37:55 PDT
Comment on attachment 371121 [details] Patch Clearing flags on attachment: 371121 Committed r246016: <https://trac.webkit.org/changeset/246016>
WebKit Commit Bot
Comment 7 2019-06-01 14:37:57 PDT
All reviewed patches have been landed. Closing bug.
Truitt Savell
Comment 8 2019-06-04 09:26:04 PDT
These two new tests are timing out on only High Sierra Debug WK1 inspector/canvas/recording-2d-full.html inspector/canvas/recording-webgl-full.html History: http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Frecording-2d-full.html%20inspector%2Fcanvas%2Frecording-webgl-full.html
Devin Rousso
Comment 9 2019-06-04 17:13:22 PDT
(In reply to Truitt Savell from comment #8) > These two new tests are timing out on only High Sierra Debug WK1 > > inspector/canvas/recording-2d-full.html > inspector/canvas/recording-webgl-full.html > > History: > http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Frecording-2d-full.html%20inspector%2Fcanvas%2Frecording-webgl-full.html This is really weird. The latest timeout seems to suggest that the test is working exactly as expected, but get's cut off before it's had a chance to print everything. Is there a way to make the timeout longer?
Truitt Savell
Comment 10 2019-06-05 07:46:46 PDT
If the test usually completes at around 29 seconds with a chance of hitting 30 seconds then we can mark the test as slow which will give it a much longer timeout time.
Truitt Savell
Comment 11 2019-06-05 07:53:48 PDT
I marked the tests as slow in r246106 to see if this will help
Note You need to log in before you can comment on or make changes to this bug.