Bug 198459 - Web Inspector: Canvas: split recording tests into separate files so they don't timeout
Summary: Web Inspector: Canvas: split recording tests into separate files so they don'...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-01 12:11 PDT by Devin Rousso
Modified: 2020-02-03 15:35 PST (History)
7 users (show)

See Also:


Attachments
Patch (326.71 KB, patch)
2019-06-01 12:27 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (328.61 KB, patch)
2019-06-01 12:42 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-01 12:11:30 PDT
.
Comment 1 Radar WebKit Bug Importer 2019-06-01 12:17:17 PDT
<rdar://problem/51332026>
Comment 2 Devin Rousso 2019-06-01 12:27:09 PDT
Created attachment 371120 [details]
Patch
Comment 3 EWS Watchlist 2019-06-01 12:29:30 PDT Comment hidden (obsolete)
Comment 4 Joseph Pecoraro 2019-06-01 12:30:15 PDT
Comment on attachment 371120 [details]
Patch

rs=me
Comment 5 Devin Rousso 2019-06-01 12:42:42 PDT
Created attachment 371121 [details]
Patch
Comment 6 WebKit Commit Bot 2019-06-01 14:37:55 PDT
Comment on attachment 371121 [details]
Patch

Clearing flags on attachment: 371121

Committed r246016: <https://trac.webkit.org/changeset/246016>
Comment 7 WebKit Commit Bot 2019-06-01 14:37:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Truitt Savell 2019-06-04 09:26:04 PDT
These two new tests are timing out on only High Sierra Debug WK1

inspector/canvas/recording-2d-full.html 
inspector/canvas/recording-webgl-full.html

History:
http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Frecording-2d-full.html%20inspector%2Fcanvas%2Frecording-webgl-full.html
Comment 9 Devin Rousso 2019-06-04 17:13:22 PDT
(In reply to Truitt Savell from comment #8)
> These two new tests are timing out on only High Sierra Debug WK1
> 
> inspector/canvas/recording-2d-full.html 
> inspector/canvas/recording-webgl-full.html
> 
> History:
> http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Frecording-2d-full.html%20inspector%2Fcanvas%2Frecording-webgl-full.html
This is really weird.  The latest timeout seems to suggest that the test is working exactly as expected, but get's cut off before it's had a chance to print everything.  Is there a way to make the timeout longer?
Comment 10 Truitt Savell 2019-06-05 07:46:46 PDT
If the test usually completes at around 29 seconds with a chance of hitting 30 seconds then we can mark the test as slow which will give it a much longer timeout time.
Comment 11 Truitt Savell 2019-06-05 07:53:48 PDT
I marked the tests as slow in r246106 to see if this will help