The following layout test is flaky on Mac WK2 iOS Simulator Debug http/wpt/service-workers/update-service-worker.https.html Probable cause: Test originally started crashing after r245873 and affected all testers Release and Debug. After r245913 (which fixed release builds) it is crashing with a different Assertion just on Debug builds. I cannot reproduce it on Release builds. The way to reproduce the failure remains the same. run-webkit-tests http/wpt/service-workers/service-worker-networkprocess-crash.html http/wpt/service-workers/update-service-worker.https.html --child-process 1 --iter 50 --exit-after-n-crashes=1 --ios-simulator --debug Usually crashes within 5 runs. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fservice-workers%2Fupdate-service-worker.https.html https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r245973%20(3961)/http/wpt/service-workers/update-service-worker.https-stderr.txt ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) /Volumes/Data/worker/trunk-peacee-ios-sim-debug-archive/build/OpenSource/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp(270) : void WebKit::NetworkProcessConnection::removeSWClientConnection(WebKit::WebSWClientConnection &) 1 0x5a321c659 WTFCrash 2 0x101d9783b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x102cc5165 WebKit::NetworkProcessConnection::removeSWClientConnection(WebKit::WebSWClientConnection&) 4 0x102d2eab3 WebKit::WebSWClientConnection::~WebSWClientConnection() 5 0x102d2ec05 WebKit::WebSWClientConnection::~WebSWClientConnection() 6 0x102d2ec69 WebKit::WebSWClientConnection::~WebSWClientConnection()
<rdar://problem/51313917>
Created attachment 371094 [details] Patch
Comment on attachment 371094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371094&action=review > Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:198 > + auto connections = WTFMove(m_swConnectionsByIdentifier); This feels like more of a std::exchange kind of use.
The bots are hitting this Assertion, and I think it might be related. ietestcenter/css3/grid/grid-column-002.htm is crashing on the testers now. Running the test by itself I cannot reproduce, running with a test list now to see what test is triggering it. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=%20ietestcenter%2Fcss3%2Fgrid%2Fgrid-column-002.htm https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r246043%20(2865)/ietestcenter/css3/grid/grid-column-002-crash-log.txt ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) /Volumes/Data/slave/mojave-debug/build/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp(270) : void WebKit::NetworkProcessConnection::removeSWClientConnection(WebKit::WebSWClientConnection &) 1 0x531230759 WTFCrash 2 0x10d9159bb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10e9e6785 WebKit::NetworkProcessConnection::removeSWClientConnection(WebKit::WebSWClientConnection&) 4 0x10ea6a913 WebKit::WebSWClientConnection::~WebSWClientConnection() 5 0x10ea6aa65 WebKit::WebSWClientConnection::~WebSWClientConnection() 6 0x10ea6aac9 WebKit::WebSWClientConnection::~WebSWClientConnection()
Comment on attachment 371094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371094&action=review >> Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:198 >> + auto connections = WTFMove(m_swConnectionsByIdentifier); > > This feels like more of a std::exchange kind of use. The containers are implemented with this ability in mind, so std::exchange does not bring any benefit. I see a slight benefit in WTFMove in terms of readability, less character and this pattern is used in many places, more than std::exchange.
Created attachment 371244 [details] Patch for landing
Comment on attachment 371244 [details] Patch for landing Clearing flags on attachment: 371244 Committed r246068: <https://trac.webkit.org/changeset/246068>
All reviewed patches have been landed. Closing bug.