Bug 198432 - REGRESSION: WebKit.InteractionDeadlockAfterCrash and SynchronousTimeoutTests.UnresponsivePageDoesNotCausePositionInformationToHangUI API tests are failing
Summary: REGRESSION: WebKit.InteractionDeadlockAfterCrash and SynchronousTimeoutTests....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-31 13:33 PDT by Tim Horton
Modified: 2019-05-31 15:02 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.47 KB, patch)
2019-05-31 13:34 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (5.57 KB, patch)
2019-05-31 14:18 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-05-31 13:33:42 PDT 
REGRESSION: WebKit.InteractionDeadlockAfterCrash and SynchronousTimeoutTests.UnresponsivePageDoesNotCausePositionInformationToHangUI API tests are failing
Comment 1 Tim Horton 2019-05-31 13:34:18 PDT 
Created attachment 371080 [details]
Patch
Comment 2 Tim Horton 2019-05-31 13:34:20 PDT 
<rdar://problem/51266033>
Comment 3 Wenson Hsieh 2019-05-31 14:01:40 PDT 
Comment on attachment 371080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371080&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:62
> +    [[webView wkContentView] hasSelectablePositionAtPoint:CGPointZero];

I just realized -wkContentView exists :P

I typically use -textInputContentView, which is nearly the same thing.
Comment 4 Tim Horton 2019-05-31 14:14:12 PDT 
🤷‍♂️ I think I added it fairly recently
Comment 5 Tim Horton 2019-05-31 14:18:27 PDT 
Created attachment 371084 [details]
Patch
Comment 6 WebKit Commit Bot 2019-05-31 15:02:20 PDT 
Comment on attachment 371084 [details]
Patch

Clearing flags on attachment: 371084

Committed r245988: <https://trac.webkit.org/changeset/245988>
Comment 7 WebKit Commit Bot 2019-05-31 15:02:22 PDT 
All reviewed patches have been landed.  Closing bug.