Bug 198422 - WebKitTestRunner sometimes freezes under -[NSWindow release]
Summary: WebKitTestRunner sometimes freezes under -[NSWindow release]
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2019-05-31 09:47 PDT by Alexey Proskuryakov
Modified: 2019-05-31 11:56 PDT (History)
5 users (show)

See Also:

proposed fix (2.66 KB, patch)
2019-05-31 09:51 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2019-05-31 09:47:10 PDT

NSWindow does some interesting things when a window that's being deallocated is still the key window. Our code for key window management that was added for gamepad testing makes it so that the window remains the key one until after dealloc, which results in a deadlock.
Comment 1 Alexey Proskuryakov 2019-05-31 09:51:25 PDT
Created attachment 371065 [details]
proposed fix
Comment 2 WebKit Commit Bot 2019-05-31 11:56:42 PDT
Comment on attachment 371065 [details]
proposed fix

Clearing flags on attachment: 371065

Committed r245975: <https://trac.webkit.org/changeset/245975>
Comment 3 WebKit Commit Bot 2019-05-31 11:56:43 PDT
All reviewed patches have been landed.  Closing bug.