Bug 198421 - Allow resizing of camera video feeds to very small resolutions
Summary: Allow resizing of camera video feeds to very small resolutions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-31 09:40 PDT by youenn fablet
Modified: 2019-06-03 14:07 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.37 KB, patch)
2019-05-31 09:52 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (11.62 KB, patch)
2019-05-31 12:28 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.97 MB, application/zip)
2019-05-31 13:23 PDT, EWS Watchlist 		no flags Details
Patch for landing (11.63 KB, patch)
2019-05-31 15:17 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-05-31 09:40:19 PDT 
Allow resizing of camera video feeds to very small resolutions
Comment 1 youenn fablet 2019-05-31 09:52:44 PDT 
Created attachment 371066 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-05-31 12:22:35 PDT 
<rdar://problem/51310872>
Comment 3 youenn fablet 2019-05-31 12:28:43 PDT 
Created attachment 371076 [details]
Patch
Comment 4 EWS Watchlist 2019-05-31 13:23:03 PDT 
Comment on attachment 371076 [details]
Patch

Attachment 371076 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12342195

New failing tests:
http/wpt/service-workers/service-worker-networkprocess-crash.html
Comment 5 EWS Watchlist 2019-05-31 13:23:04 PDT 
Created attachment 371079 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 6 youenn fablet 2019-05-31 14:59:50 PDT 
Comment on attachment 371079 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

Unrelated
Comment 7 Alex Christensen 2019-05-31 15:09:10 PDT 
Comment on attachment 371076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371076&action=review

> Source/WebCore/ChangeLog:9
> +        Since this is a bit arbitrarily and there are some usecases for lower resolution,

arbitrary

> Source/WebCore/ChangeLog:10
> +        We now allow up to 1x1 resolution.

down to
Comment 8 youenn fablet 2019-05-31 15:17:39 PDT 
Created attachment 371091 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2019-06-03 14:07:52 PDT 
Comment on attachment 371091 [details]
Patch for landing

Clearing flags on attachment: 371091

Committed r246049: <https://trac.webkit.org/changeset/246049>
Comment 10 WebKit Commit Bot 2019-06-03 14:07:53 PDT 
All reviewed patches have been landed.  Closing bug.