RESOLVED FIXED198415
[ews-app] Add authentication while fetching bugs 
https://bugs.webkit.org/show_bug.cgi?id=198415
Summary [ews-app] Add authentication while fetching bugs
Aakash Jain
Reported 2019-05-31 04:47:37 PDT
Add bugzilla authentication to Django ews-app for fetching bug list with r? flag, and the individual bugs.
Attachments
WIP (5.95 KB, patch)
2019-05-31 05:58 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (4.39 KB, patch)
2019-06-04 09:04 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (3.92 KB, patch)
2019-06-04 11:37 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-31 04:47:47 PDT
<rdar://problem/51298710>
Aakash Jain
Comment 2 2019-05-31 05:58:55 PDT
Created attachment 371052 [details] WIP
Aakash Jain
Comment 3 2019-06-04 09:04:58 PDT
Created attachment 371288 [details] Patch
Jonathan Bedard
Comment 4 2019-06-04 10:13:41 PDT
Comment on attachment 371288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371288&action=review > Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py:110 > + if self.authenticated: This code concerns me. What happens if we authenticate, and then this class sticks around for too long, and bugzilla logs us out? If that happens, we have no recourse. I would think that we would set authenticated to false at the beginning on this function. > Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py:136 > + if attempts < 5: Can we do: if attempts >= 5: raise Exception(errorMessage) _log.error(errorMessage) time.sleep(5)
Aakash Jain
Comment 5 2019-06-04 11:34:26 PDT
Comment on attachment 371288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371288&action=review >> Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py:110 >> + if self.authenticated: > > This code concerns me. > > What happens if we authenticate, and then this class sticks around for too long, and bugzilla logs us out? If that happens, we have no recourse. I would think that we would set authenticated to false at the beginning on this function. Agree.. modified to remove caching. >> Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py:136 >> + if attempts < 5: > > Can we do: > > if attempts >= 5: > raise Exception(errorMessage) > _log.error(errorMessage) > time.sleep(5) Modified in updated patch.
Aakash Jain
Comment 6 2019-06-04 11:37:07 PDT
Created attachment 371312 [details] Patch
Aakash Jain
Comment 7 2019-06-04 14:40:02 PDT
Comment on attachment 371312 [details] Patch Clearing flags on attachment: 371312 Committed r246082: <https://trac.webkit.org/changeset/246082>
Aakash Jain
Comment 8 2019-06-04 14:40:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.