Bug 198412 - [iOS] Reveal the focused element when it's immediately above software keyboard
Summary: [iOS] Reveal the focused element when it's immediately above software keyboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-31 01:42 PDT by Ryosuke Niwa
Modified: 2019-05-31 16:13 PDT (History)
4 users (show)

See Also:

Attachments
Fixes the bug (8.54 KB, patch)
2019-05-31 01:53 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-05-31 01:42:32 PDT 
On iPad, we don't force scrolling to reveal the focused element when the element is entirely visible.
This can be misleading in cases where there is more content right beneath it relevant for editing operations.

Zoom & scroll to reveal the focused element when the said element is right above the software keyboard.

<rdar://problem/50633287>
Comment 1 Ryosuke Niwa 2019-05-31 01:53:14 PDT 
Created attachment 371045 [details]
Fixes the bug
Comment 2 Wenson Hsieh 2019-05-31 08:01:19 PDT 
Comment on attachment 371045 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=371045&action=review

We should double check that this doesn't cause the scroll position to jump in Mail compose when focusing the body field by tapping near the bottom of the compose window.

> LayoutTests/fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad.html:33
> +        UIHelper.isIOS = () => true;

OOPS! I filed <rdar://problem/51301737> to track this.
Comment 3 Ryosuke Niwa 2019-05-31 16:13:40 PDT 
Comment on attachment 371045 [details]
Fixes the bug

Clearing flags on attachment: 371045

Committed r245993: <https://trac.webkit.org/changeset/245993>
Comment 4 Ryosuke Niwa 2019-05-31 16:13:42 PDT 
All reviewed patches have been landed.  Closing bug.