Bug 198400 - [CMake] Add WebKit::WTF target
Summary: [CMake] Add WebKit::WTF target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-30 18:13 PDT by Don Olmstead
Modified: 2019-05-31 09:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.17 KB, patch)
2019-05-30 18:34 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (15.07 KB, patch)
2019-05-31 06:46 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-05-30 18:13:25 PDT 
Use WEBKIT_FRAMEWORK_TARGET for WTF.
Comment 1 Don Olmstead 2019-05-30 18:34:32 PDT 
Created attachment 371011 [details]
Patch
Comment 2 Konstantin Tokarev 2019-05-31 06:42:22 PDT 
MiniBrowser failed to build on Win EWS: 

c:\cygwin\home\buildbot\webkit\tools\minibrowser\win\stdafx.h(34): fatal error C1083: Cannot open include file: 'cmakeconfig.h': No such file or directory (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\MiniBrowser\win\WinMain.cpp)
Comment 3 Don Olmstead 2019-05-31 06:46:04 PDT 
Created attachment 371055 [details]
Patch
Comment 4 Konstantin Tokarev 2019-05-31 06:49:31 PDT 
Comment on attachment 371055 [details]
Patch

r=me if WTF is happy
Comment 5 Konstantin Tokarev 2019-05-31 08:10:29 PDT 
Comment on attachment 371055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371055&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [CMake] Add WebKit::WTF target

BTW, this commit message is not accurate: you don't add WebKit::WTF target (it was added previously), but use it instead of WTF${DEBUG_SUFFIX}.
Comment 6 Don Olmstead 2019-05-31 08:32:38 PDT 
(In reply to Konstantin Tokarev from comment #5)
> Comment on attachment 371055 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371055&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        [CMake] Add WebKit::WTF target
> 
> BTW, this commit message is not accurate: you don't add WebKit::WTF target
> (it was added previously), but use it instead of WTF${DEBUG_SUFFIX}.

There was a patch that added it but it got rolled out
Comment 7 WebKit Commit Bot 2019-05-31 09:56:09 PDT 
Comment on attachment 371055 [details]
Patch

Clearing flags on attachment: 371055

Committed r245968: <https://trac.webkit.org/changeset/245968>
Comment 8 WebKit Commit Bot 2019-05-31 09:56:11 PDT 
All reviewed patches have been landed.  Closing bug.