RESOLVED FIXED 198400
[CMake] Add WebKit::WTF target 
https://bugs.webkit.org/show_bug.cgi?id=198400
Summary [CMake] Add WebKit::WTF target
Don Olmstead
Reported 2019-05-30 18:13:25 PDT
Use WEBKIT_FRAMEWORK_TARGET for WTF.
Attachments
Patch (15.17 KB, patch)
2019-05-30 18:34 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (15.07 KB, patch)
2019-05-31 06:46 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-05-30 18:34:32 PDT
Created attachment 371011 [details] Patch
Konstantin Tokarev
Comment 2 2019-05-31 06:42:22 PDT
MiniBrowser failed to build on Win EWS: c:\cygwin\home\buildbot\webkit\tools\minibrowser\win\stdafx.h(34): fatal error C1083: Cannot open include file: 'cmakeconfig.h': No such file or directory (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\MiniBrowser\win\WinMain.cpp)
Don Olmstead
Comment 3 2019-05-31 06:46:04 PDT
Created attachment 371055 [details] Patch
Konstantin Tokarev
Comment 4 2019-05-31 06:49:31 PDT
Comment on attachment 371055 [details] Patch r=me if WTF is happy
Konstantin Tokarev
Comment 5 2019-05-31 08:10:29 PDT
Comment on attachment 371055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371055&action=review > Source/JavaScriptCore/ChangeLog:3 > + [CMake] Add WebKit::WTF target BTW, this commit message is not accurate: you don't add WebKit::WTF target (it was added previously), but use it instead of WTF${DEBUG_SUFFIX}.
Don Olmstead
Comment 6 2019-05-31 08:32:38 PDT
(In reply to Konstantin Tokarev from comment #5) > Comment on attachment 371055 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371055&action=review > > > Source/JavaScriptCore/ChangeLog:3 > > + [CMake] Add WebKit::WTF target > > BTW, this commit message is not accurate: you don't add WebKit::WTF target > (it was added previously), but use it instead of WTF${DEBUG_SUFFIX}. There was a patch that added it but it got rolled out
WebKit Commit Bot
Comment 7 2019-05-31 09:56:09 PDT
Comment on attachment 371055 [details] Patch Clearing flags on attachment: 371055 Committed r245968: <https://trac.webkit.org/changeset/245968>
WebKit Commit Bot
Comment 8 2019-05-31 09:56:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.