Bug 198395 – Web Inspector: remove RemoteObject.prototype.getPropertyDescriptorsAsObject

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

When calling `remoteObject.getPropertyDescriptorsAsObject`, if one of the returned property descriptors is named `__proto__`, it will replace the `__proto__` of the plain object created for that function with the `WI.PropertyDescriptor`, altering the prototype chain.  This is not a good thing.

Since this function is only used in a few places, we should remove it entirely.

[Devin Rousso]

Created attachment 371022 [details]
Patch

[EWS Watchlist]

Comment on attachment 371022 [details]
Patch

Attachment 371022 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12335099

New failing tests:
inspector/audit/data-domNodes.html
inspector/audit/data-domAttributes.html
inspector/audit/data-errors.html

[EWS Watchlist]

Created attachment 371025 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371022 [details]
Patch

Attachment 371022 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12335267

New failing tests:
inspector/audit/data-domNodes.html
inspector/audit/data-domAttributes.html
inspector/audit/data-errors.html

[EWS Watchlist]

Created attachment 371026 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371022 [details]
Patch

Attachment 371022 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12335345

New failing tests:
inspector/audit/data-domNodes.html
inspector/audit/data-domAttributes.html
inspector/audit/data-errors.html

[EWS Watchlist]

Created attachment 371030 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Devin Rousso]

Created attachment 371033 [details]
Patch

Integer vs String comparison -.-

[Matt Baker]

Comment on attachment 371033 [details]
Patch

r=me, nice fix.

Since ErrorObjectView.prototype.update is only called internally, and isn't an override, let's make it private or even inline it inside ErrorObjectView.prototype.expand, which is the only call site.

[Devin Rousso]

(In reply to Matt Baker from comment #9)
> Since ErrorObjectView.prototype.update is only called internally, and isn't an override, let's make it private or even inline it inside ErrorObjectView.prototype.expand, which is the only call site.
I'd rather not make a change like this as it's frankly unnecessary for this patch, and could be more prone to issues than what I'd tested.  Furthermore, I'm actually a fan of the idea of modularizing functionality, even if it's only used once, as it makes code easier to read and more future-capable.

[WebKit Commit Bot]

Comment on attachment 371033 [details]
Patch

Clearing flags on attachment: 371033

Committed r246046: <https://trac.webkit.org/changeset/246046>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51366626>