Bug 198390 – Some WeakPtr cleanup

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

Some WeakPtr cleanup

[Geoffrey Garen]

Created attachment 370988 [details]
Patch

[EWS Watchlist]

Attachment 370988 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/WeakPtr.h:102:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 370988 [details]
Patch

Attachment 370988 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12335269

New failing tests:
http/wpt/service-workers/service-worker-networkprocess-crash.html

[EWS Watchlist]

Created attachment 371031 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Geoffrey Garen]

Comment on attachment 370988 [details]
Patch

EWS iOS-sim seems unrelated.

[Chris Dumez]

Comment on attachment 370988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370988&action=review

> Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h:57
> +    typedef IDBClient::IDBConnectionToServerDelegate::WeakValueType WeakValueType;

I think we like using statements better than typedef nowadays.

[Geoffrey Garen]

> > Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h:57
> > +    typedef IDBClient::IDBConnectionToServerDelegate::WeakValueType WeakValueType;
> 
> I think we like using statements better than typedef nowadays.

I agree. Unfortunately, in this case, our Windows and Linux compilers can't seem to handle a using statement. (See EWS failures in https://bugs.webkit.org/show_bug.cgi?id=188799, like https://webkit-queues.webkit.org/results/12311701 and https://webkit-queues.webkit.org/results/12310577.)

[Geoffrey Garen]

Comment on attachment 370988 [details]
Patch

cq+

[Chris Dumez]

Comment on attachment 370988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370988&action=review

>> Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h:57
>> +    typedef IDBClient::IDBConnectionToServerDelegate::WeakValueType WeakValueType;
> 
> I think we like using statements better than typedef nowadays.

I meant:
using WeakValueType = IDBClient::IDBConnectionToServerDelegate::WeakValueType;

[WebKit Commit Bot]

Comment on attachment 370988 [details]
Patch

Clearing flags on attachment: 370988

Committed r245972: <https://trac.webkit.org/changeset/245972>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51305690>

[Geoffrey Garen]

> I meant:
> using WeakValueType =
> IDBClient::IDBConnectionToServerDelegate::WeakValueType;

Got it. I'll do this in https://bugs.webkit.org/show_bug.cgi?id=198431.