Bug 19839 - A PDF,RLE sequence that should be a no-op affects bidi reordering
Summary: A PDF,RLE sequence that should be a no-op affects bidi reordering
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: data:text/html,<div style="direction:...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-07-01 00:52 PDT by mitz
Modified: 2010-06-10 16:12 PDT (History)
1 user (show)

See Also:


Attachments
Fix for the HTML/CSS flavor of this bug, including change log and regression test (89.21 KB, patch)
2008-10-21 23:20 PDT, mitz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2008-07-01 00:52:43 PDT
In the URL, the letters should be orderer "a b", because the PDF,RLE sequence in the middle has the net effect of not changing the embedding level of any character. However, the URL is rendered as "b a". The reason is that BidiResolver::embed() always behaves as if the embedding operation creates a run boundary (and so terminates the current run and sets the "last" and "last strong" directions for the next run).
Comment 1 mitz 2008-10-20 14:04:48 PDT
<rdar://problem/6304805>
Comment 2 mitz 2008-10-21 23:20:00 PDT
Created attachment 24550 [details]
Fix for the HTML/CSS flavor of this bug, including change log and regression test

The bug affects both the use of Unicode bidi control characters (such as in the URL) and the use of the CSS 'direction' and 'unicode-bidi' properties. This patch fixes the bug only for the latter case. I suggest doing this first, and keeping the bug open.
Comment 3 Sam Weinig 2008-10-23 14:42:43 PDT
Comment on attachment 24550 [details]
Fix for the HTML/CSS flavor of this bug, including change log and regression test

r=me, with no hesitation.
Comment 4 mitz 2008-10-23 14:57:23 PDT
Fix for the HTML/CSS flavor landed in <http://trac.webkit.org/changeset/37828>.