RESOLVED FIXED Bug 198386
[PlayStation] Support internal test runner for JSC tests
https://bugs.webkit.org/show_bug.cgi?id=198386
Summary [PlayStation] Support internal test runner for JSC tests
Stephan Szabo
Reported 2019-05-30 13:14:18 PDT
For PlayStation, support speeding up the JSC tests by running multiple tests sequentially in one execution using our internal test runner. Some of the things we'd need to use are local to the jsc shell file and for now since it's just our port, we're wrapping the file and adding the function definitions used from our library rather than reorganizing the shell for everyone. One change outside of PlayStation specific code is to export the defaults for the JSC options similarly to the actual values to get them when resetting the options between runs when the JavaScriptCore library is built dynamically.
Attachments
Patch (4.56 KB, patch)
2019-05-30 13:23 PDT, Stephan Szabo
ews-watchlist: commit-queue-
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.73 MB, application/zip)
2019-05-30 16:42 PDT, EWS Watchlist
no flags
Patch (4.56 KB, patch)
2019-05-31 09:37 PDT, Stephan Szabo
achristensen: review+
achristensen: commit-queue-
Patch (5.73 KB, patch)
2019-05-31 15:40 PDT, Stephan Szabo
no flags
Stephan Szabo
Comment 1 2019-05-30 13:23:22 PDT
EWS Watchlist
Comment 2 2019-05-30 16:42:04 PDT
Comment on attachment 370972 [details] Patch Attachment 370972 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12332338 New failing tests: http/wpt/service-workers/useragent.https.html
EWS Watchlist
Comment 3 2019-05-30 16:42:05 PDT
Created attachment 370996 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Stephan Szabo
Comment 4 2019-05-31 09:37:21 PDT
Alex Christensen
Comment 5 2019-05-31 15:05:33 PDT
Comment on attachment 371064 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371064&action=review > Source/JavaScriptCore/shell/playstation/TestShell.cpp:13 > + * 3. Neither the name of Apple Inc. ("Apple") nor the names of We typically use a 2-clause copyright header now. This was copied from a very old file.
Stephan Szabo
Comment 6 2019-05-31 15:40:01 PDT
Created attachment 371092 [details] Patch Updated copyright header to 2-clause version, not entirely sure where that originally copied from.
WebKit Commit Bot
Comment 7 2019-05-31 17:01:00 PDT
Comment on attachment 371092 [details] Patch Clearing flags on attachment: 371092 Committed r246003: <https://trac.webkit.org/changeset/246003>
WebKit Commit Bot
Comment 8 2019-05-31 17:01:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-05-31 17:01:39 PDT
Note You need to log in before you can comment on or make changes to this bug.