Bug 198371 - [CoordinatedGraphics] WPERenderer: do not release the host file descritor when initializing the render target
Summary: [CoordinatedGraphics] WPERenderer: do not release the host file descritor whe...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2019-05-30 05:28 PDT by Carlos Garcia Campos
Modified: 2019-05-31 01:15 PDT (History)
6 users (show)

See Also:

Patch (3.04 KB, patch)
2019-05-30 05:33 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews215 for win-future (13.55 MB, application/zip)
2019-05-30 06:57 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-05-30 05:28:33 PDT
We are assuming that there will always be only one target for a web page. In the GTK port (and WinCairo once they enable coordinated graphics) we destroy the render target when leaving AC mode, and a new one is created when re-entering AC mode. Since the file descriptor is released on the first target and adopted by libwpe, the second target passes -1 as host fd to libwpe, and the new surface created by the target is not properly registered in the wayland compositor. That means that frame requests for the new target are simply ignored by the wayland compositor, it returns early on surfacxe frame when the surface doesn't have a view backend client.
Comment 1 Carlos Garcia Campos 2019-05-30 05:33:03 PDT
Created attachment 370937 [details]
Comment 2 EWS Watchlist 2019-05-30 06:57:46 PDT
Comment on attachment 370937 [details]

Attachment 370937 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12327703

New failing tests:
Comment 3 EWS Watchlist 2019-05-30 06:57:49 PDT
Created attachment 370940 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Carlos Garcia Campos 2019-05-31 01:15:16 PDT
Committed r245956: <https://trac.webkit.org/changeset/245956>