WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198370
[ews-build] Update configuration to share bots across queues
https://bugs.webkit.org/show_bug.cgi?id=198370
Summary
[ews-build] Update configuration to share bots across queues
Aakash Jain
Reported
2019-05-30 05:13:25 PDT
Share bots across builder and tester queues in order to increase efficiency of the system. So that when bots are idle on one queue they can process patches on other queues.
Attachments
Patch
(1.91 KB, patch)
2019-05-30 05:16 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2019-05-30 05:16:38 PDT
Created
attachment 370935
[details]
Patch
Jonathan Bedard
Comment 2
2019-05-30 08:13:01 PDT
Comment on
attachment 370935
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=370935&action=review
> Tools/ChangeLog:8 > + * BuildSlaveSupport/ews-build/config.json: Share bots across builder and API tester queues.
Will we eventually do this with layout testers too?
> Tools/ChangeLog:10 > + noted in
https://bugs.webkit.org/show_bug.cgi?id=197571#c1
Can't we just fix the keychain on that bot?
Aakash Jain
Comment 3
2019-05-30 08:50:04 PDT
> Will we eventually do this with layout testers too?
Haven't planned that yet.
> Can't we just fix the keychain on that bot?
Yeah, someone need to debug that further.
WebKit Commit Bot
Comment 4
2019-05-30 09:17:11 PDT
Comment on
attachment 370935
[details]
Patch Clearing flags on attachment: 370935 Committed
r245886
: <
https://trac.webkit.org/changeset/245886
>
WebKit Commit Bot
Comment 5
2019-05-30 09:17:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-05-30 09:18:16 PDT
<
rdar://problem/51263202
>
Alexey Proskuryakov
Comment 7
2019-05-30 09:36:33 PDT
I'm not sure about this change. Sharing bots means that long term effects of tests will also be breaking builders now. It was nice to know what was happening on a bot that panicked or froze - e.g issues on a builder are more likely to mean hardware failures. Sharing machines makes maintenance harder.
> > Can't we just fix the keychain on that bot? > Yeah, someone need to debug that further.
I don't think that there is anything to debug, we just need to erase install it.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug