Bug 198366 - [LFC[IFC] Do not reuse the same Line object.
Summary: [LFC[IFC] Do not reuse the same Line object.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-29 21:47 PDT by zalan
Modified: 2019-05-31 06:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (13.84 KB, patch)
2019-05-29 21:52 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.19 KB, patch)
2019-05-31 06:13 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-05-29 21:47:24 PDT 
while laying out the lines.
Comment 1 Radar WebKit Bug Importer 2019-05-29 21:47:45 PDT 
<rdar://problem/51250279>
Comment 2 zalan 2019-05-29 21:52:26 PDT 
Created attachment 370920 [details]
Patch
Comment 3 Antti Koivisto 2019-05-30 05:08:16 PDT 
Comment on attachment 370920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370920&action=review

> Source/WebCore/layout/inlineformatting/InlineLine.h:38
>  class Line {
>  public:

You should WTF_MAKE_FAST_ALLOCATED here since this is now heap allocated.
Comment 4 zalan 2019-05-31 06:13:27 PDT 
Created attachment 371053 [details]
Patch
Comment 5 WebKit Commit Bot 2019-05-31 06:43:43 PDT 
Comment on attachment 371053 [details]
Patch

Clearing flags on attachment: 371053

Committed r245962: <https://trac.webkit.org/changeset/245962>
Comment 6 WebKit Commit Bot 2019-05-31 06:43:45 PDT 
All reviewed patches have been landed.  Closing bug.