Bug 198351 - Clean up a few #include statements in WTF
Summary: Clean up a few #include statements in WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-29 14:35 PDT by David Kilzer (:ddkilzer)
Modified: 2019-05-29 16:08 PDT (History)
11 users (show)

See Also:


Attachments
Patch v1 (2.42 KB, patch)
2019-05-29 14:38 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2019-05-29 14:35:23 PDT
Clean up a few #include statements in WTF.

Found using this command from Bug 198349:

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WTF 2>&1 | grep -i primary
Comment 1 David Kilzer (:ddkilzer) 2019-05-29 14:37:42 PDT
NOTE: The style bot will report errors until Bug 198349 is fixed.
Comment 2 David Kilzer (:ddkilzer) 2019-05-29 14:38:14 PDT
Created attachment 370885 [details]
Patch v1
Comment 3 Build Bot 2019-05-29 14:40:44 PDT
Attachment 370885 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/StackBounds.cpp:22:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WTF/wtf/StackBounds.cpp:23:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WTF/wtf/ParallelJobsGeneric.cpp:29:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 David Kilzer (:ddkilzer) 2019-05-29 14:41:43 PDT
Need to wait for WPE/Win builds to complete since Source/WTF/wtf/ParallelJobsGeneric.cpp is only built by those ports.
Comment 5 WebKit Commit Bot 2019-05-29 16:07:36 PDT
Comment on attachment 370885 [details]
Patch v1

Clearing flags on attachment: 370885

Committed r245876: <https://trac.webkit.org/changeset/245876>
Comment 6 WebKit Commit Bot 2019-05-29 16:07:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-05-29 16:08:16 PDT
<rdar://problem/51241724>