Video playback in Safari should continue when CarPlay is plugged in
<rdar://problem/45505750>
Created attachment 370875 [details] Patch
Comment on attachment 370875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370875&action=review > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:213 > + setIsPlayingToAutomotiveHeadUnit(carPlayIsConnected.value()); Shouldn't this be: setIsPlayingToAutomotiveHeadUnit(carPlayIsConnected && carPlayIsConnected.value()) > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:312 > + callOnWebThreadOrDispatchAsyncOnMainThread([protectedSelf = retainPtr(self)]() mutable { :-/ > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:450 > + protectedSelf->_callback->carPlayServerDied(); _callback should be NULL-checked, it may have been clear by the time this runs > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:467 > + protectedSelf->_callback->updateCarPlayIsConnected(WTFMove(carPlayIsConnected)); Ditto. > LayoutTests/media/video-isplayingtoautomotiveheadunit.html:11 > + findMediaElement(); > + > + run('video.src = findMediaFile("video", "content/test")'); :-O TABS!
Comment on attachment 370875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370875&action=review >> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:213 >> + setIsPlayingToAutomotiveHeadUnit(carPlayIsConnected.value()); > > Shouldn't this be: setIsPlayingToAutomotiveHeadUnit(carPlayIsConnected && carPlayIsConnected.value()) Yeah, it probably should be (in the case that we can't load the CarPlayIsConnectedAttribute). >> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:450 >> + protectedSelf->_callback->carPlayServerDied(); > > _callback should be NULL-checked, it may have been clear by the time this runs Will do.
Created attachment 370944 [details] Patch for landing
Created attachment 370945 [details] Patch for landing
Comment on attachment 370945 [details] Patch for landing Clearing flags on attachment: 370945 Committed r245887: <https://trac.webkit.org/changeset/245887>
All reviewed patches have been landed. Closing bug.
Fixed iOS build in https://trac.webkit.org/changeset/245890/webkit
(In reply to Truitt Savell from comment #9) > Fixed iOS build in https://trac.webkit.org/changeset/245890/webkit Thanks Truitt!
This change broke internal builds, details in email and radar. Reverted in https://trac.webkit.org/r245944
Committed r245947: <https://trac.webkit.org/changeset/245947>