Bug 198342 - Fix builds that don't use makeWindowFromView
Summary: Fix builds that don't use makeWindowFromView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-29 11:02 PDT by Keith Rollin
Modified: 2019-05-29 12:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2019-05-29 11:05 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-05-29 11:02:56 PDT
In some configurations, VideoFullscreenInterfaceAVKit.mm declares but does not use makeWindowFromView. Fix by conditionalizing the the declaration on the same symbol as point where it's used.
Comment 1 Radar WebKit Bug Importer 2019-05-29 11:03:49 PDT
<rdar://problem/51228563>
Comment 2 Keith Rollin 2019-05-29 11:05:05 PDT
Created attachment 370866 [details]
Patch
Comment 3 WebKit Commit Bot 2019-05-29 12:16:42 PDT
Comment on attachment 370866 [details]
Patch

Clearing flags on attachment: 370866

Committed r245861: <https://trac.webkit.org/changeset/245861>
Comment 4 WebKit Commit Bot 2019-05-29 12:16:43 PDT
All reviewed patches have been landed.  Closing bug.