RESOLVED FIXED 19833
REGRESSION(r34754): Start profile button in profiler now profiles inspector rather than actual page 
https://bugs.webkit.org/show_bug.cgi?id=19833
Summary REGRESSION(r34754): Start profile button in profiler now profiles inspector r...
Oliver Hunt
Reported 2008-06-30 19:31:00 PDT
I just found that when starting a profile by clicking the button to start profiles in the inspector results in us reporting profile data for the inspector which seems wholly unhelpful. To reproduce * Go to http://nerget.com/ParticleJS/Particles.html * Open the inspector * Go to the profile pane * Click the profile button * Wait a wee while * Stop the profile * Admire the profile of the inspector.
Attachments
Add attachment proposed patch, testcase, etc.
Kevin McCullough
Comment 1 2008-07-10 14:04:48 PDT
rdar://problem/6067178
Kevin McCullough
Comment 2 2008-07-10 14:38:04 PDT
It looks like r34753 is the culprit.
Adam Barth
Comment 3 2008-07-10 14:43:12 PDT
I'll take a look at this tonight.
Kevin McCullough
Comment 4 2008-07-10 15:03:33 PDT
Although that revision does not look like it could have possibly caused the issue. I think the inspector needs to call startUserInitiatedProfiling() instead of console.profile();
Kevin McCullough
Comment 5 2008-07-10 15:49:51 PDT
Scratch that calling InspectorController.inspectedWindow().console should contextually be correct in that it should call the console on the inspected window.
Adam Barth
Comment 6 2008-07-10 16:19:29 PDT
> It looks like r34753 is the culprit. Hum... I can't repro the bug at r34753 but I can repro it at r34754. http://trac.webkit.org/changeset/34754 That change seems more relevant as touches lines of code that actually run in this case.
Kevin McCullough
Comment 7 2008-07-10 17:18:07 PDT
Yeah I re-ran my tests and I also think r18754 is the real culprit. Sorry to waste your time. I just need to figure out how this caused the regression.
Kevin McCullough
Comment 8 2008-07-10 17:38:47 PDT
I'm guessing that somewhere under JSInspectedObjectWrapper::wrapone of these wrappers is holding the wrong ExecState.
Kevin McCullough
Comment 9 2008-07-11 15:43:59 PDT
Committed revision 35140.
Note You need to log in before you can comment on or make changes to this bug.