Bug 198326 - PlatformEventKeyboardGtk still uses old key aliases
Summary: PlatformEventKeyboardGtk still uses old key aliases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-29 02:49 PDT by Ludovico de Nittis
Modified: 2019-05-29 06:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (25.60 KB, patch)
2019-05-29 03:01 PDT, Ludovico de Nittis
no flags Details | Formatted Diff | Diff
Patch (42.27 KB, patch)
2019-05-29 03:21 PDT, Ludovico de Nittis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ludovico de Nittis 2019-05-29 02:49:40 PDT
GTK added a "KEY_" prefix to every key names.

The support for GTK3 has been added with this commit https://gitlab.gnome.org/GNOME/gtk/commit/913cdf3be750a1e74c09b20edf55a57f9a919fcc
and for GTK2 (from 2.21.8) with this commit https://gitlab.gnome.org/GNOME/gtk/commit/750c81f43dda6c783372b983e630ecd30b776d7e


While on GTK2 and GTK3 it is still possible to use the old name scheme, on GTK4 only the new one is available.
So it should be better to stick with the new name convention to ease a future GTK4 porting.


I'm going to attach a patch to this issue.
Comment 1 Ludovico de Nittis 2019-05-29 03:01:21 PDT
Created attachment 370836 [details]
Patch
Comment 2 Build Bot 2019-05-29 03:02:34 PDT
Attachment 370836 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:779:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:1300:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ludovico de Nittis 2019-05-29 03:21:06 PDT
Created attachment 370837 [details]
Patch
Comment 4 Carlos Garcia Campos 2019-05-29 04:23:20 PDT
Comment on attachment 370837 [details]
Patch

Thanks!
Comment 5 WebKit Commit Bot 2019-05-29 06:07:08 PDT
Comment on attachment 370837 [details]
Patch

Clearing flags on attachment: 370837

Committed r245849: <https://trac.webkit.org/changeset/245849>
Comment 6 WebKit Commit Bot 2019-05-29 06:07:09 PDT
All reviewed patches have been landed.  Closing bug.