Bug 198322 - Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
Summary: Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-28 19:03 PDT by Justin Michaud
Modified: 2019-05-29 16:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2019-05-28 19:05 PDT, Justin Michaud 		no flags Details | Formatted Diff | Diff
patch (3.43 KB, patch)
2019-05-28 19:49 PDT, Justin Michaud 		no flags Details | Formatted Diff | Diff
Patch (3.47 KB, patch)
2019-05-29 16:18 PDT, Justin Michaud 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2019-05-28 19:03:20 PDT 
Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
Comment 1 Justin Michaud 2019-05-28 19:05:50 PDT 
Created attachment 370822 [details]
Patch
Comment 3 Justin Michaud 2019-05-28 19:49:00 PDT 
Created attachment 370824 [details]
patch

Rubber stamped by Saam
Comment 4 WebKit Commit Bot 2019-05-28 20:27:54 PDT 
Comment on attachment 370824 [details]
patch

Clearing flags on attachment: 370824

Committed r245843: <https://trac.webkit.org/changeset/245843>
Comment 5 WebKit Commit Bot 2019-05-28 20:27:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2019-05-29 13:14:09 PDT 
We're still seeing 7 test timeouts after this change:


** The following JSC stress test failures have been introduced:
	wasm.yaml/wasm/function-tests/context-switch.js.wasm-collect-continuously
	wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-collect-continuously
	wasm.yaml/wasm/function-tests/memory-alignment.js.wasm-collect-continuously
	wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-collect-continuously
	wasm.yaml/wasm/js-api/Instance.imports.exports.unicode.js.wasm-collect-continuously
	wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-collect-continuously
	wasm.yaml/wasm/js-api/export-arity.js.wasm-collect-continuously

https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/2902
Comment 7 Radar WebKit Bug Importer 2019-05-29 13:14:25 PDT 
<rdar://problem/51233848>
Comment 8 Justin Michaud 2019-05-29 16:18:09 PDT 
Reopening to attach new patch.
Comment 9 Justin Michaud 2019-05-29 16:18:09 PDT 
Created attachment 370895 [details]
Patch
Comment 10 Justin Michaud 2019-05-29 16:19:16 PDT 
Comment on attachment 370895 [details]
Patch

Rubber stamped by Michael Saboff. Disable running the new collectContinuously tests on debug builds. This matches what we do for other jsc tests.
Comment 11 WebKit Commit Bot 2019-05-29 16:54:04 PDT 
Comment on attachment 370895 [details]
Patch

Clearing flags on attachment: 370895

Committed r245879: <https://trac.webkit.org/changeset/245879>
Comment 12 WebKit Commit Bot 2019-05-29 16:54:05 PDT 
All reviewed patches have been landed.  Closing bug.