Bug 198307 – Add an option to mute audio capture automatically when page is not visible

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Add an option to mute audio capture automatically when page is not visible

[youenn fablet]

Created attachment 370807 [details]
Patch

[youenn fablet]

Created attachment 370851 [details]
Patch

[youenn fablet]

<rdar://problem/47390407>

[Eric Carlson]

Comment on attachment 370851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370851&action=review

> Source/WebCore/ChangeLog:9
> +        In case document gets in the background, interrupt the audio track if the audio factory allows it.

Nit: s/allows/requires/

> Source/WebCore/ChangeLog:10
> +        CoreAudioCaptureSourceIOS allows to interrupt the audio capture if the app has not the right background mode.

Nit: s/allows to interrupt the audio source/requires the audio source be interrupted/

[youenn fablet]

Created attachment 370862 [details]
Patch for landing

[Jon Lee]

Comment on attachment 370862 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=370862&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm:2
> + * Copyright (C) 2013-2016 Apple, Inc. All rights reserved.

2019.

[youenn fablet]

Created attachment 370967 [details]
Patch for landing

[youenn fablet]

Created attachment 370986 [details]
Patch for landing

[EWS Watchlist]

Comment on attachment 370986 [details]
Patch for landing

Attachment 370986 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12333645

New failing tests:
http/wpt/cache-storage/quota-third-party.https.html

[EWS Watchlist]

Created attachment 371013 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[WebKit Commit Bot]

Comment on attachment 370986 [details]
Patch for landing

Clearing flags on attachment: 370986

Committed r245946: <https://trac.webkit.org/changeset/245946>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

Rolled out in https://trac.webkit.org/changeset/245964/webkit because it breaks the watchOS build.

[youenn fablet]

Created attachment 371060 [details]
Fixing watchOS build

[WebKit Commit Bot]

Comment on attachment 371060 [details]
Fixing watchOS build

Rejecting attachment 371060 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 371060, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
=371060&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=198307&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 371060 from bug 198307.
Fetching: https://bugs.webkit.org/attachment.cgi?id=371060
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	C	Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb => Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm
	A	LayoutTests/platform/ios/mediastream/audio-muted-in-background-tab-expected.txt
	A	LayoutTests/platform/ios/mediastream/audio-muted-in-background-tab.html
	M	LayoutTests/ChangeLog
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/SourcesCocoa.txt
	M	Source/WebCore/WebCore.xcodeproj/project.pbxproj
	M	Source/WebCore/dom/Document.cpp
	M	Source/WebCore/page/RuntimeEnabledFeatures.h
	M	Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
	M	Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h
	M	Source/WebCore/platform/mediastream/RealtimeMediaSourceFactory.h
	M	Source/WebCore/platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm
	M	Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h
	M	Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp
	M	Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
	M	Source/WebCore/testing/Internals.cpp
	M	Source/WebCore/testing/Internals.h
	M	Source/WebCore/testing/Internals.idl
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 55f594ac9f3fd5273a212606f0dceaf7be808a17 and refs/remotes/origin/master differ, using rebase:
:040000 040000 1230136b9b74a5966400983208e4e8d5921913fb 2e077803358ecc7244b1692ee4b3ea4fbcbeb3fd M	LayoutTests
:040000 040000 0a855a405d6b608d587f38b9859a41491f6d5381 5981c2cdcac9ec169150f644f3c455888f60cc7a M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	C	Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb => Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm
	A	LayoutTests/platform/ios/mediastream/audio-muted-in-background-tab-expected.txt
	A	LayoutTests/platform/ios/mediastream/audio-muted-in-background-tab.html
	M	LayoutTests/ChangeLog
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/SourcesCocoa.txt
	M	Source/WebCore/WebCore.xcodeproj/project.pbxproj
	M	Source/WebCore/dom/Document.cpp
	M	Source/WebCore/page/RuntimeEnabledFeatures.h
	M	Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
	M	Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h
	M	Source/WebCore/platform/mediastream/RealtimeMediaSourceFactory.h
	M	Source/WebCore/platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm
	M	Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h
	M	Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp
	M	Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
	M	Source/WebCore/testing/Internals.cpp
	M	Source/WebCore/testing/Internals.h
	M	Source/WebCore/testing/Internals.idl
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 55f594ac9f3fd5273a212606f0dceaf7be808a17 and refs/remotes/origin/master differ, using rebase:
:040000 040000 1230136b9b74a5966400983208e4e8d5921913fb 2e077803358ecc7244b1692ee4b3ea4fbcbeb3fd M	LayoutTests
:040000 040000 0a855a405d6b608d587f38b9859a41491f6d5381 5981c2cdcac9ec169150f644f3c455888f60cc7a M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   df5a375eb87..f44ba58dc92  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 245991 = df5a375eb87899610d78a85f85086f850824d31e
r245992 = 4c3a48aae99551cb30fd5188dc9b63f7eb71e7b8
r245993 = 102cb1d36e2df616c4ceb48a899de2302ccf68cb
r245994 = c52c2cb53e45d2c7dcb4aff67d159fc751229584
r245995 = f44ba58dc9288debbc647a54036bca56132653e7
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/12344244

[WebKit Commit Bot]

Comment on attachment 371060 [details]
Fixing watchOS build

Clearing flags on attachment: 371060

Committed r246002: <https://trac.webkit.org/changeset/246002>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.