Use scroll-velocity-based tile coverage for overflow:scroll
Created attachment 370746 [details] Patch
Attachment 370746 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileController.cpp:549: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/ca/PlatformCALayer.h:102: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 370746 [details] Patch Attachment 370746 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12308930 New failing tests: compositing/video/video-border-radius.html css3/blending/blend-mode-clip-rect-accelerated-blending.html css3/blending/blend-mode-clip-accelerated-blending-double.html css3/blending/blend-mode-clip-accelerated-transformed-blending.html css3/blending/blend-mode-clip-accelerated-blending-with-siblings.html compositing/shared-backing/shared-layer-has-reflection.html css3/blending/blend-mode-clip-accelerated-blending-child.html compositing/clipping/border-radius-stacking-context-clip.html legacy-animation-engine/compositing/transitions/transform-on-large-layer.html imported/blink/css3/blending/mix-blend-mode-has-ancestor-clipping-layer.html compositing/masks/tiled-mask.html imported/blink/fast/css/fixed-overlaps-absolute-in-clip.html compositing/transitions/transform-on-large-layer.html css3/blending/blend-mode-accelerated-parent-overflow-hidden.html media/video-poster-background.html compositing/hidpi-ancestor-subpixel-clipping.html
Created attachment 370753 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 370746 [details] Patch Attachment 370746 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12308945 New failing tests: css3/blending/blend-mode-clip-accelerated-blending-double.html css3/blending/blend-mode-clip-accelerated-blending-child.html compositing/clipping/border-radius-stacking-context-clip.html scrollingcoordinator/mac/rtl-programmatic-overflow-scroll.html imported/blink/fast/css/fixed-overlaps-absolute-in-clip.html legacy-animation-engine/compositing/transitions/transform-on-large-layer.html media/video-poster-background.html compositing/hidpi-ancestor-subpixel-clipping.html css3/blending/blend-mode-clip-rect-accelerated-blending.html compositing/geometry/composited-frame-contents.html compositing/masks/tiled-mask.html compositing/transitions/transform-on-large-layer.html scrollingcoordinator/mac/programmatic-overflow-scroll.html compositing/shared-backing/shared-layer-has-reflection.html tiled-drawing/top-content-inset-fixed-attachment-local.html compositing/geometry/fixed-inside-overflow-scroll.html tiled-drawing/top-content-inset-fixed-attachment-body.html tiled-drawing/top-content-inset-fixed-attachment-cover-local.html compositing/video/video-border-radius.html fast/layers/no-clipping-overflow-hidden-added-after-transform.html css3/blending/blend-mode-clip-accelerated-transformed-blending.html css3/blending/blend-mode-clip-accelerated-blending-with-siblings.html imported/blink/css3/blending/mix-blend-mode-has-ancestor-clipping-layer.html tiled-drawing/top-content-inset-fixed-attachment.html css3/blending/blend-mode-accelerated-parent-overflow-hidden.html
Created attachment 370757 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 370746 [details] Patch Attachment 370746 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12308931 New failing tests: compositing/video/video-border-radius.html css3/blending/blend-mode-clip-rect-accelerated-blending.html css3/blending/blend-mode-clip-accelerated-blending-double.html css3/blending/blend-mode-clip-accelerated-transformed-blending.html css3/blending/blend-mode-clip-accelerated-blending-with-siblings.html compositing/shared-backing/shared-layer-has-reflection.html css3/blending/blend-mode-clip-accelerated-blending-child.html compositing/clipping/border-radius-stacking-context-clip.html legacy-animation-engine/compositing/transitions/transform-on-large-layer.html imported/blink/css3/blending/mix-blend-mode-has-ancestor-clipping-layer.html compositing/masks/tiled-mask.html imported/blink/fast/css/fixed-overlaps-absolute-in-clip.html compositing/transitions/transform-on-large-layer.html fast/scrolling/ios/overflow-scroll-overlap.html css3/blending/blend-mode-accelerated-parent-overflow-hidden.html media/video-poster-background.html compositing/hidpi-ancestor-subpixel-clipping.html
Created attachment 370762 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Comment on attachment 370746 [details] Patch Attachment 370746 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12308959 New failing tests: compositing/video/video-border-radius.html css3/blending/blend-mode-clip-rect-accelerated-blending.html css3/blending/blend-mode-clip-accelerated-blending-double.html css3/blending/blend-mode-clip-accelerated-transformed-blending.html css3/blending/blend-mode-clip-accelerated-blending-with-siblings.html compositing/shared-backing/shared-layer-has-reflection.html css3/blending/blend-mode-clip-accelerated-blending-child.html compositing/clipping/border-radius-stacking-context-clip.html legacy-animation-engine/compositing/transitions/transform-on-large-layer.html imported/blink/css3/blending/mix-blend-mode-has-ancestor-clipping-layer.html compositing/masks/tiled-mask.html imported/blink/fast/css/fixed-overlaps-absolute-in-clip.html compositing/transitions/transform-on-large-layer.html css3/blending/blend-mode-accelerated-parent-overflow-hidden.html media/video-poster-background.html compositing/hidpi-ancestor-subpixel-clipping.html
Created attachment 370763 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 370746 [details] Patch Attachment 370746 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12309022 New failing tests: imported/blink/fast/css/fixed-overlaps-absolute-in-clip.html imported/blink/compositing/squashing/overflow-scroll-grandchildren.html
Created attachment 370766 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 370788 [details] Patch
<rdar://problem/48942184>
Attachment 370788 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/PlatformCALayer.h:102: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 370788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370788&action=review > Source/WebCore/platform/graphics/ca/TileController.cpp:433 > + // FIXME: look at how far the document can scroll in each dimension. Capital L :D > Source/WebCore/platform/graphics/ca/TileController.cpp:455 > + auto expandRectWithinRect = [](const FloatRect& rect, const FloatSize& newSize, const FloatRect& constrainingRect) { Why this lambda? It's only called once and doesn't make use of early returns or anything.
Comment on attachment 370788 [details] Patch Clearing flags on attachment: 370788 Committed r245837: <https://trac.webkit.org/changeset/245837>
All reviewed patches have been landed. Closing bug.