Bug 198290 - [WinCairo][MediaFoundation] Assertion failure in MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSample
Summary: [WinCairo][MediaFoundation] Assertion failure in MediaPlayerPrivateMediaFound...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-28 03:32 PDT by Fujii Hironori
Modified: 2019-05-28 21:36 PDT (History)
5 users (show)

See Also:

Attachments
default-size-should-show-scrubber-crash-log.txt (149.78 KB, text/plain)
2019-05-28 03:32 PDT, Fujii Hironori 		no flags Details
Patch (4.48 KB, patch)
2019-05-28 03:43 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (1.84 KB, patch)
2019-05-28 03:45 PDT, Fujii Hironori 		pvollan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-05-28 03:32:06 PDT 
Created attachment 370721 [details]
default-size-should-show-scrubber-crash-log.txt

[WinCairo][MediaFoundation] Assertion failure in MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSample

Some media tests are failing due to assertion failure in MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSample.
For example,

> python ./Tools/Scripts/run-webkit-tests --debug  --wincairo --no-new-test-results --dump-render-tree media/controls/default-size-should-show-scrubber.html

Callstack:


> [WTF!WTFCrash+0xe]
> [WebKit!WTFCrashWithInfo+0x20]
> [WebKit!COMPtr<IDirect3DSurface9>::operator&+0x6a]
> [WebKit!WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSample+0x2de]
> [WebKit!WebCore::MediaPlayerPrivateMediaFoundation::VideoScheduler::scheduleSample+0x113]
> [WebKit!WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::deliverSample+0xe2]
> [WebKit!WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::processOutput+0x6c9]
> [WebKit!WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::SetVideoPosition+0x348]
> [WebKit!WebCore::MediaPlayerPrivateMediaFoundation::setSize+0x3cf]
> [WebKit!WebCore::MediaPlayer::setSize+0x46]
> [WebKit!WebCore::RenderVideo::updatePlayer+0x1cd]
> [WebKit!WebCore::RenderVideo::layout+0x53]
> [WebKit!WebCore::RenderElement::layoutIfNeeded+0x46]
> [WebKit!WebCore::RenderBlockFlow::layoutLineBoxes+0x7fe]
> [WebKit!WebCore::RenderBlockFlow::layoutInlineChildren+0xc8]
> [WebKit!WebCore::RenderBlockFlow::layoutBlock+0x49b]
> [WebKit!WebCore::RenderBlock::layout+0x81]
> [WebKit!WebCore::RenderBlockFlow::layoutBlockChild+0x497]
> [WebKit!WebCore::RenderBlockFlow::layoutBlockChildren+0x2d6]
> [WebKit!WebCore::RenderBlockFlow::layoutBlock+0x4c0]
> [WebKit!WebCore::RenderBlock::layout+0x81]
> [WebKit!WebCore::RenderBlockFlow::layoutBlockChild+0x497]
> [WebKit!WebCore::RenderBlockFlow::layoutBlockChildren+0x2d6]
> [WebKit!WebCore::RenderBlockFlow::layoutBlock+0x4c0]
> [WebKit!WebCore::RenderBlock::layout+0x81]
> [WebKit!WebCore::RenderBlockFlow::layoutBlockChild+0x497]
> [WebKit!WebCore::RenderBlockFlow::layoutBlockChildren+0x2d6]
> [WebKit!WebCore::RenderBlockFlow::layoutBlock+0x4c0]
> [WebKit!WebCore::RenderBlock::layout+0x81]
> [WebKit!WebCore::RenderView::layout+0x576]
> [WebKit!WebCore::FrameViewLayoutContext::layout+0x972]
> [WebKit!WebCore::Document::updateLayout+0x272]
> [WebKit!WebCore::Document::updateLayoutIgnorePendingStylesheets+0x62]
> [WebKit!WebCore::Element::boundingClientRect+0x4a]
> [WebKit!WebCore::Element::getBoundingClientRect+0x37]
> [WebKit!WebCore::jsElementPrototypeFunctionGetBoundingClientRectBody+0x40]
> [WebKit!WebCore::IDLOperation<WebCore::JSElement>::call<&WebCore::jsElementPrototypeFunctionGetBoundingClientRectBody,WebCore::CastedThisErrorBehavior::Throw>+0x305]
> [WebKit!WebCore::jsElementPrototypeFunctionGetBoundingClientRect+0x1a]
Comment 1 Fujii Hironori 2019-05-28 03:43:50 PDT 
Created attachment 370722 [details]
Patch
Comment 2 Fujii Hironori 2019-05-28 03:45:03 PDT 
Created attachment 370723 [details]
Patch
Comment 3 Per Arne Vollan 2019-05-28 07:32:23 PDT 
Comment on attachment 370723 [details]
Patch

R=me. I think the api-mac failure must be unrelated, since this patch only touches Windows platform code.
Comment 4 Fujii Hironori 2019-05-28 21:35:34 PDT 
Landed: https://trac.webkit.org/changeset/245845/webkit
Comment 5 Radar WebKit Bug Importer 2019-05-28 21:36:19 PDT 
<rdar://problem/51208024>