[AppleWin] Assertion failure in defaultSupportedImageTypes in UTIRegistry.cpp An assertion fails in AppleWin port Debug builds. > ASSERT(CFArrayContainsValue(systemImageTypes.get(), CFRangeMake(0, count), string.get())); Callstack: > WebKit.dll!abort() Line 77 C++ > WebKit.dll!WTFCrashWithInfo(int __formal, const char * __formal, const char * __formal, int __formal) Line 569 C++ > WebKit.dll!WebCore::defaultSupportedImageTypes::__l2::<lambda>() Line 67 C++ > [External Code] > [Frames below may be incorrect and/or missing, no symbols loaded for ntdll.dll] > WebKit.dll!WebCore::defaultSupportedImageTypes() Line 62 C++ > WebKit.dll!WebCore::MIMETypeRegistry::supportedImageMIMETypes::__l2::<lambda>() Line 153 C++ > [External Code] > WebKit.dll!WebCore::MIMETypeRegistry::supportedImageMIMETypes() Line 152 C++ > WebKit.dll!WebCore::MIMETypeRegistry::isSupportedImageMIMEType(const WTF::String & mimeType) Line 457 C++ > WebKit.dll!WebView::canShowMIMEType(const WTF::String & mimeType) Line 2979 C++ > WebKit.dll!WebView::canShowMIMEType(wchar_t * mimeType, int * canShow) Line 2967 C++ > WebKit.dll!DefaultPolicyDelegate::decidePolicyForMIMEType(IWebView * webView, wchar_t * type, IWebURLRequest * request, IWebFrame * __formal, IWebPolicyDecisionListener * listener) Line 146 C++ > WebKit.dll!WebFrameLoaderClient::dispatchDecidePolicyForResponse(const WebCore::ResourceResponse & response, const WebCore::ResourceRequest & request, WebCore::PolicyCheckIdentifier identifier, const WTF::String & __formal, WTF::Function<void __cdecl(enum WebCore::PolicyAction,WebCore::PolicyCheckIdentifier)> && function) Line 544 C++ > WebKit.dll!WebCore::FrameLoader::checkContentPolicy(const WebCore::ResourceResponse & response, WebCore::PolicyCheckIdentifier identifier, WTF::Function<void __cdecl(enum WebCore::PolicyAction,WebCore::PolicyCheckIdentifier)> && function) Line 376 C++ > WebKit.dll!WebCore::DocumentLoader::responseReceived(const WebCore::ResourceResponse & response, WTF::CompletionHandler<void __cdecl(void)> && completionHandler) Line 848 C++ > WebKit.dll!WebCore::DocumentLoader::responseReceived(WebCore::CachedResource & resource, const WebCore::ResourceResponse & response, WTF::CompletionHandler<void __cdecl(void)> && completionHandler) Line 755 C++ > WebKit.dll!WebCore::CachedRawResource::responseReceived(const WebCore::ResourceResponse & response) Line 225 C++ > WebKit.dll!WebCore::SubresourceLoader::didReceiveResponse(const WebCore::ResourceResponse & response, WTF::CompletionHandler<void __cdecl(void)> && policyCompletionHandler) Line 383 C++ > WebKit.dll!WebCore::ResourceLoader::didReceiveResponseAsync(WebCore::ResourceHandle * __formal, WebCore::ResourceResponse && response, WTF::CompletionHandler<void __cdecl(void)> && completionHandler) Line 681 C++ > WebKit.dll!WebCore::ResourceHandle::didReceiveResponse(WebCore::ResourceResponse && response, WTF::CompletionHandler<void __cdecl(void)> && completionHandler) Line 167 C++ > WebKit.dll!WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse::__l2::<lambda>() Line 204 C++ > WebKit.dll!WTF::Detail::CallableWrapper<void <lambda>(void),void>::call() Line 52 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 79 C++ > WTF.dll!WTF::dispatchFunctionsFromMainThread() Line 116 C++ > WTF.dll!WTF::ThreadingWindowWndProc(HWND__ * hWnd, unsigned int message, unsigned int wParam, long lParam) Line 49 C++ > [External Code] > WebKit.dll!WebKitMessageLoop::run(HACCEL__ * hAccelTable) Line 94 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 97 C++ > MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 116 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 232 C++ > [External Code]
Created attachment 370719 [details] Patch
Comment on attachment 370719 [details] Patch Attachment 370719 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12306929 New failing tests: fast/events/mouse-cursor-image-set.html fast/events/mouse-cursor.html fast/images/favicon-as-image.html http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials.html fast/images/icon-0colors.html fast/images/icon-decoding.html http/tests/misc/favicon-as-image.html
Created attachment 370725 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
(In reply to Build Bot from comment #2) > Comment on attachment 370719 [details] > Patch > > Attachment 370719 [details] did not pass win-ews (win): > Output: https://webkit-queues.webkit.org/results/12306929 > > New failing tests: > fast/events/mouse-cursor-image-set.html > fast/events/mouse-cursor.html > fast/images/favicon-as-image.html > http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials. > html > fast/images/icon-0colors.html > fast/images/icon-decoding.html > http/tests/misc/favicon-as-image.html I am not sure why these tests are failing. Maybe the bots support these image types?
Created attachment 378623 [details] Patch
Comment on attachment 378623 [details] Patch Win EWS tests passed!
Per, do you have a chance to review this patch?
Comment on attachment 378623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378623&action=review This seems reasonable. > Source/WebCore/platform/graphics/cg/ImageSourceCGWin.cpp:-41 > - // public.xbitmap-image, com.apple.quicktime-image, and others. Do we really need to remove this comment?
Comment on attachment 378623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378623&action=review >> Source/WebCore/platform/graphics/cg/ImageSourceCGWin.cpp:-41 >> - // public.xbitmap-image, com.apple.quicktime-image, and others. > > Do we really need to remove this comment? Ok, will restore.
Created attachment 378931 [details] Patch for landing
Committed r249938: <https://trac.webkit.org/changeset/249938>
<rdar://problem/55425626>
After this change, AppleWin Debug buildbot completed running layout tests! https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Tests%29/builds/2866 > 32 failures 388 new passes 7 flakes