RESOLVED FIXED Bug 198283
[JSC] Enable 16bit CLoop Win
https://bugs.webkit.org/show_bug.cgi?id=198283
Summary [JSC] Enable 16bit CLoop Win
Yusuke Suzuki
Reported 2019-05-28 00:14:36 PDT
...
Attachments
Yusuke Suzuki
Comment 1 2019-05-30 15:41:41 PDT
Windows CLoop in MSVC is half-broken state right now. MSVC can compile it, the semantics of the compiled CLoop::execute seems fine. The problem is, not sure why, MSVC compiled CLoop::execute requires massive amount of stack space... I don't check it carefully, but inserting some currentStackPointer() and diffing the values say CLoop::execute takes almost 100KB stack space. It does not make sense, CLoop::execute should take very few amount of stack space. This leads to very easy stack overflow everywhere. If you call CLoop::execute in a nested manner (maybe) 10 times, then you will see stack-overflow range error will be thrown. I think we should rather switching to LLInt ASM interpreter for Windows.
Radar WebKit Bug Importer
Comment 2 2024-05-18 23:11:15 PDT
Yusuke Suzuki
Comment 3 2024-05-18 23:12:23 PDT
EWS
Comment 4 2024-05-19 01:11:28 PDT
Committed 278968@main (2c77a224cdd2): <https://commits.webkit.org/278968@main> Reviewed commits have been landed. Closing PR #28767 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.