Bug 198282 - [LFC][IFC] Decouple line layout and processing inline runs.
Summary: [LFC][IFC] Decouple line layout and processing inline runs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-27 21:33 PDT by zalan
Modified: 2019-05-28 08:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.27 KB, patch)
2019-05-27 21:36 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.30 KB, patch)
2019-05-27 21:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.30 KB, patch)
2019-05-28 07:55 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-05-27 21:33:21 PDT 
So that we could use the inline run processing logic for preferred width computation too.
Comment 1 zalan 2019-05-27 21:36:17 PDT 
Created attachment 370712 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-05-27 21:36:31 PDT 
<rdar://problem/51167954>
Comment 3 Radar WebKit Bug Importer 2019-05-27 21:37:18 PDT 
<rdar://problem/51167959>
Comment 4 zalan 2019-05-27 21:37:22 PDT 
Created attachment 370713 [details]
Patch
Comment 5 Antti Koivisto 2019-05-28 02:38:08 PDT 
Comment on attachment 370713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370713&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:62
> +        unsigned createInlineRunsForLine(Line&, unsigned firstInlineItemIndex) const;

Not super clear what the return value means.
Comment 6 zalan 2019-05-28 07:54:01 PDT 
(In reply to Antti Koivisto from comment #5)
> Comment on attachment 370713 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370713&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:62
> > +        unsigned createInlineRunsForLine(Line&, unsigned firstInlineItemIndex) const;
> 
> Not super clear what the return value means.
Yeah, you are right. I'll address this in the next patch!
Comment 7 zalan 2019-05-28 07:55:10 PDT 
Created attachment 370739 [details]
Patch
Comment 8 WebKit Commit Bot 2019-05-28 08:36:11 PDT 
Comment on attachment 370739 [details]
Patch

Clearing flags on attachment: 370739

Committed r245812: <https://trac.webkit.org/changeset/245812>
Comment 9 WebKit Commit Bot 2019-05-28 08:36:13 PDT 
All reviewed patches have been landed.  Closing bug.