Bug 198270 - Web Inspector: Audit: tests are unable to get the current Audit version
Summary: Web Inspector: Audit: tests are unable to get the current Audit version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: WebInspectorAuditTab
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-27 00:32 PDT by Devin Rousso
Modified: 2019-05-30 16:17 PDT (History)
12 users (show)

See Also:


Attachments
Patch (6.94 KB, patch)
2019-05-27 00:39 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (6.95 KB, patch)
2019-05-27 01:15 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2019-05-27 01:21 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (6.97 KB, patch)
2019-05-27 01:21 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.08 MB, application/zip)
2019-05-27 02:21 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.68 MB, application/zip)
2019-05-27 02:36 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews115 for mac-highsierra (2.93 MB, application/zip)
2019-05-27 03:10 PDT, EWS Watchlist
no flags Details
Patch (6.98 KB, patch)
2019-05-27 11:48 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-05-27 00:32:57 PDT
We should be exposing the Audit version number in tests in addition to checking for it as a `supports` value. This way, tests can decide whether they're `{level: "unsupported"}` at runtime, instead of immediately at the start.
Comment 1 Devin Rousso 2019-05-27 00:39:11 PDT
Created attachment 370675 [details]
Patch
Comment 2 Devin Rousso 2019-05-27 01:15:21 PDT
Created attachment 370676 [details]
Patch
Comment 3 Devin Rousso 2019-05-27 01:21:11 PDT
Created attachment 370677 [details]
Patch
Comment 4 Devin Rousso 2019-05-27 01:21:47 PDT
Created attachment 370678 [details]
Patch
Comment 5 EWS Watchlist 2019-05-27 02:21:02 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2019-05-27 02:21:04 PDT Comment hidden (obsolete)
Comment 7 EWS Watchlist 2019-05-27 02:36:16 PDT Comment hidden (obsolete)
Comment 8 EWS Watchlist 2019-05-27 02:36:18 PDT Comment hidden (obsolete)
Comment 9 EWS Watchlist 2019-05-27 03:10:52 PDT Comment hidden (obsolete)
Comment 10 EWS Watchlist 2019-05-27 03:10:54 PDT Comment hidden (obsolete)
Comment 11 Devin Rousso 2019-05-27 11:48:05 PDT
Created attachment 370700 [details]
Patch
Comment 12 WebKit Commit Bot 2019-05-30 16:15:15 PDT
Comment on attachment 370700 [details]
Patch

Clearing flags on attachment: 370700

Committed r245909: <https://trac.webkit.org/changeset/245909>
Comment 13 WebKit Commit Bot 2019-05-30 16:15:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2019-05-30 16:17:02 PDT
<rdar://problem/51281268>