Bug 198267 - [iOS] Dropping in an editable element shouldn't result in a ranged selection
Summary: [iOS] Dropping in an editable element shouldn't result in a ranged selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-26 21:21 PDT by Wenson Hsieh
Modified: 2019-05-27 22:09 PDT (History)
7 users (show)

See Also:

Attachments
Patch (19.61 KB, patch)
2019-05-26 22:49 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-05-26 21:21:21 PDT 
<rdar://problem/51145977>
Comment 1 Wenson Hsieh 2019-05-26 22:49:56 PDT 
Created attachment 370669 [details]
Patch
Comment 2 Wenson Hsieh 2019-05-27 15:09:59 PDT 
> Failures in API Test first run: set([u'TestWebKitAPI._WKDownload.DownloadMonitorCancel'])
> Failures in API Test second run: set([u'TestWebKitAPI._WKDownload.DownloadMonitorCancel'])
> Flaky Tests: set([])
> Failures in API Test on clean tree: set([])
> New failures: set([u'TestWebKitAPI._WKDownload.DownloadMonitorCancel'])

The macOS API test failure seems unrelated.
Comment 3 Tim Horton 2019-05-27 17:26:22 PDT 
Comment on attachment 370669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370669&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:881
>      static auto defaultTextIndicatorOptionsForEditDrag = TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection | TextIndicatorOptionExpandClipBeyondVisibleRect | TextIndicatorOptionPaintAllContent | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection | TextIndicatorOptionPaintBackgrounds | TextIndicatorOptionComputeEstimatedBackgroundColor| TextIndicatorOptionUseSelectionRectForSizing | TextIndicatorOptionIncludeSnapshotWithSelectionHighlight;

Ho-ly crap
Comment 4 Wenson Hsieh 2019-05-27 17:35:17 PDT 
Comment on attachment 370669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370669&action=review

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:881
>>      static auto defaultTextIndicatorOptionsForEditDrag = TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection | TextIndicatorOptionExpandClipBeyondVisibleRect | TextIndicatorOptionPaintAllContent | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection | TextIndicatorOptionPaintBackgrounds | TextIndicatorOptionComputeEstimatedBackgroundColor| TextIndicatorOptionUseSelectionRectForSizing | TextIndicatorOptionIncludeSnapshotWithSelectionHighlight;
> 
> Ho-ly crap

Quite :/
Comment 5 WebKit Commit Bot 2019-05-27 18:03:15 PDT 
Comment on attachment 370669 [details]
Patch

Clearing flags on attachment: 370669

Committed r245803: <https://trac.webkit.org/changeset/245803>
Comment 6 WebKit Commit Bot 2019-05-27 18:03:17 PDT 
All reviewed patches have been landed.  Closing bug.